Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: components/image_fetcher/image_data_fetcher.cc

Issue 2674653003: Use IOSImageDataFetcherWrapper in BrowserViewController (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/image_fetcher/image_data_fetcher.cc
diff --git a/components/image_fetcher/image_data_fetcher.cc b/components/image_fetcher/image_data_fetcher.cc
index 708bf3affda5e8027eccded578519c39d67a2ed2..a7be16e5a32d76b2064fcd3ff3c8c17e18af8ef1 100644
--- a/components/image_fetcher/image_data_fetcher.cc
+++ b/components/image_fetcher/image_data_fetcher.cc
@@ -47,9 +47,18 @@ void ImageDataFetcher::SetDataUseServiceName(
void ImageDataFetcher::FetchImageData(
const GURL& url, const ImageDataFetcherCallback& callback) {
Marc Treib 2017/02/02 15:19:13 Not your doing, but url should be image_url to mat
gambard 2017/02/03 12:11:34 Done.
- std::unique_ptr<net::URLFetcher> url_fetcher =
- net::URLFetcher::Create(
- next_url_fetcher_id_++, url, net::URLFetcher::GET, this);
+ ImageDataFetcher::FetchImageData(
+ url, callback, std::string(),
Marc Treib 2017/02/02 15:19:13 Please add a comment for the empty string param, l
gambard 2017/02/03 12:11:34 Done.
+ net::URLRequest::CLEAR_REFERRER_ON_TRANSITION_FROM_SECURE_TO_INSECURE);
+}
+
+void ImageDataFetcher::FetchImageData(
+ const GURL& image_url,
+ const ImageDataFetcherCallback& callback,
+ const std::string& referrer,
+ net::URLRequest::ReferrerPolicy referrer_policy) {
Marc Treib 2017/02/02 15:19:13 You should actually do something with the referrer
gambard 2017/02/03 12:11:34 Oooops :) Done!
+ std::unique_ptr<net::URLFetcher> url_fetcher = net::URLFetcher::Create(
+ next_url_fetcher_id_++, image_url, net::URLFetcher::GET, this);
DataUseUserData::AttachToFetcher(url_fetcher.get(), data_use_service_name_);

Powered by Google App Engine
This is Rietveld 408576698