Use IOSImageDataFetcherWrapper in BrowserViewController

components/image_fetcher/image_data_fetcher.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/image_fetcher/image_data_fetcher.h"
 
 #include "net/base/load_flags.h"
 #include "net/url_request/url_fetcher.h"
 #include "net/url_request/url_request.h"
 #include "net/url_request/url_request_context_getter.h"
@@ skipping 28 matching lines @@
       next_url_fetcher_id_(0) {}
 
 ImageDataFetcher::~ImageDataFetcher() {}
 
 void ImageDataFetcher::SetDataUseServiceName(
     DataUseServiceName data_use_service_name) {
   data_use_service_name_ = data_use_service_name;
 }
 
 void ImageDataFetcher::FetchImageData(
     const GURL& url, const ImageDataFetcherCallback& callback) {

[Marc Treib, 2017/02/02 15:19:13]

Not your doing, but url should be image_url to match the header.

[gambard, 2017/02/03 12:11:34]

Done.

-  std::unique_ptr<net::URLFetcher> url_fetcher =
-      net::URLFetcher::Create(
-          next_url_fetcher_id_++, url, net::URLFetcher::GET, this);
+  ImageDataFetcher::FetchImageData(
+      url, callback, std::string(),

[Marc Treib, 2017/02/02 15:19:13]

Please add a comment for the empty string param, like this:
/*referrer=*/std::string()

[gambard, 2017/02/03 12:11:34]

Done.

+      net::URLRequest::CLEAR_REFERRER_ON_TRANSITION_FROM_SECURE_TO_INSECURE);
+}
+
+void ImageDataFetcher::FetchImageData(
+    const GURL& image_url,
+    const ImageDataFetcherCallback& callback,
+    const std::string& referrer,
+    net::URLRequest::ReferrerPolicy referrer_policy) {

[Marc Treib, 2017/02/02 15:19:13]

You should actually do something with the referrer and policy :)

[gambard, 2017/02/03 12:11:34]

Oooops :)
Done!

+  std::unique_ptr<net::URLFetcher> url_fetcher = net::URLFetcher::Create(
+      next_url_fetcher_id_++, image_url, net::URLFetcher::GET, this);
 
   DataUseUserData::AttachToFetcher(url_fetcher.get(), data_use_service_name_);
 
   std::unique_ptr<ImageDataFetcherRequest> request(
       new ImageDataFetcherRequest(callback, std::move(url_fetcher)));
   request->url_fetcher->SetRequestContext(url_request_context_getter_.get());
   request->url_fetcher->Start();
 
   pending_requests_[request->url_fetcher.get()] = std::move(request);
 }
 
 void ImageDataFetcher::OnURLFetchComplete(const net::URLFetcher* source) {
   auto request_iter = pending_requests_.find(source);
   DCHECK(request_iter != pending_requests_.end());
 
   std::string image_data;
   if (source->GetStatus().status() == net::URLRequestStatus::SUCCESS) {
     source->GetResponseAsString(&image_data);
   }
   request_iter->second->callback.Run(image_data);
 
   // Remove the finished request.
   pending_requests_.erase(request_iter);
 }
 
 }  // namespace image_fetcher