git cl format //device/sensors

git cl format //device/sensors

After we moved the //content/browser/device_sensors to //device/sensors,
we use this separate CL to do "git cl formatting".
The log tag "cr.sensors" is changed into "sensors" in DeviceSensors.java to
eliminates the presubmit warnings.

BUG=612322
Review-Url: https://codereview.chromium.org/2674613003
Cr-Commit-Position: refs/heads/master@{#451208}
Committed: https://chromium.googlesource.com/chromium/src/+/f6fb3e420e012be507b027e747dc819d7fb4da73

[ke.he, 2017-02-02 15:51:48]

Description was changed from

==========
git cl format //device/sensors

After we moved the //content/browser/device_sensors to //device/sensors,
we use this separate CL to do "git cl formatting".
The log tag "cr.sensors" is changed into "sensors" in DeviceSensors.java to
eliminates the presubmit warnings.

BUG=612322

Move //content/browser/device_sensor/ into device/sensors

This patch moves device_sensor related files out of //content/browser and into
//device/sensors. In next patch we will port it into Device Service.

The DeviceSensors.java and DeviceSensorsTest.java are also moved into //device
The device_sensor_browsertest.cc is still in //content/browser/device_sensor/

BUG=612322
==========

to

==========
git cl format //device/sensors

After we moved the //content/browser/device_sensors to //device/sensors,
we use this separate CL to do "git cl formatting".
The log tag "cr.sensors" is changed into "sensors" in DeviceSensors.java to
eliminates the presubmit warnings.

BUG=612322
==========

[ke.he, 2017-02-02 15:52:49]

Patchset #1 (id:1) has been deleted

[ke.he, 2017-02-02 15:53:05]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 15:53:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ke.he, 2017-02-02 16:45:31]

ke.he@intel.com changed reviewers:
+ blundell@chromium.org, timvolodine@chromium.org

[ke.he, 2017-02-02 16:45:32]

Hi, Colin and Tim: we use this separate CL to do "git cl format" for
//device/sensors. PTAL. Thanks!

[commit-bot: I haz the power, 2017-02-02 17:34:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 17:34:18]

Dry run: This issue passed the CQ dry run.

[ke.he, 2017-02-03 03:30:16]

Hi, Tim, by the way, I found the VibrationManagerImpl.java is in //device while
the VibrationManagerImplTest.java is still in //content. I'd like to move it
into //device similar as we did for DeviceSensorsTest.java  :)

[ke.he, 2017-02-03 03:38:54]

On 2017/02/03 03:30:16, ke.he wrote:
> Hi, Tim, by the way, I found the VibrationManagerImpl.java is in //device
while
> the VibrationManagerImplTest.java is still in //content. I'd like to move it
> into //device similar as we did for DeviceSensorsTest.java  :)

Sorry, It seems have dependency on content and not so straightforward to
decouple :(

[blundell, 2017-02-03 08:36:52]

On 2017/02/03 03:38:54, ke.he wrote:
> On 2017/02/03 03:30:16, ke.he wrote:
> > Hi, Tim, by the way, I found the VibrationManagerImpl.java is in //device
> while
> > the VibrationManagerImplTest.java is still in //content. I'd like to move it
> > into //device similar as we did for DeviceSensorsTest.java  :)
> 
> Sorry, It seems have dependency on content and not so straightforward to
> decouple :(

Could you file a bug for this? Please give it the label "DeviceService" and
block crbug.com/686693 on it.

[blundell, 2017-02-03 08:37:21]

I defer to Tim for the review here. My strong preference always to just take
what clang-format outputs.

[ke.he, 2017-02-07 08:24:35]

Hi, Tim, friendly ping:)

[ke.he, 2017-02-15 02:24:28]

Hi, Tim, How about this CL? There is lots of presubmit warnings in
//device/sensors.
Or, if there is no need to change the format in //device/sensors, I'm ok to drop
this patch either:)

[timvolodine, 2017-02-15 22:17:28]

thanks, sorry for the delay fell off my radar.. two comments below, otherwise
looks good.

https://codereview.chromium.org/2674613003/diff/20001/device/sensors/android/...
File
device/sensors/android/java/src/org/chromium/device/sensors/DeviceSensors.java
(right):

https://codereview.chromium.org/2674613003/diff/20001/device/sensors/android/...
device/sensors/android/java/src/org/chromium/device/sensors/DeviceSensors.java:369:
values[1] = Math.asin(matrixR[7]); // beta (-pi/2, pi/2)
can we keep the alignment here (and below) pls, it was done on purpose
oringinally

https://codereview.chromium.org/2674613003/diff/20001/device/sensors/sensor_m...
File device/sensors/sensor_manager_chromeos_unittest.cc (right):

https://codereview.chromium.org/2674613003/diff/20001/device/sensors/sensor_m...
device/sensors/sensor_manager_chromeos_unittest.cc:25:
~TestSensorManagerChromeOS() override{};
this is weird, the methods below were not corrected, probably revert?

[ke.he, 2017-02-16 06:22:15]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 06:23:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 08:43:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 08:43:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ke.he, 2017-02-16 09:13:49]

Tim, Thank you!  CL is updated. PTAL.

https://codereview.chromium.org/2674613003/diff/20001/device/sensors/android/...
File
device/sensors/android/java/src/org/chromium/device/sensors/DeviceSensors.java
(right):

https://codereview.chromium.org/2674613003/diff/20001/device/sensors/android/...
device/sensors/android/java/src/org/chromium/device/sensors/DeviceSensors.java:369:
values[1] = Math.asin(matrixR[7]); // beta (-pi/2, pi/2)
On 2017/02/15 22:17:28, timvolodine wrote:
> can we keep the alignment here (and below) pls, it was done on purpose
> oringinally

Done.

https://codereview.chromium.org/2674613003/diff/20001/device/sensors/sensor_m...
File device/sensors/sensor_manager_chromeos_unittest.cc (right):

https://codereview.chromium.org/2674613003/diff/20001/device/sensors/sensor_m...
device/sensors/sensor_manager_chromeos_unittest.cc:25:
~TestSensorManagerChromeOS() override{};
On 2017/02/15 22:17:28, timvolodine wrote:
> this is weird, the methods below were not corrected, probably revert?

There is a surplus ";" at the end which led to a different format. Let me delete
it:)

[timvolodine, 2017-02-16 23:31:02]

okay thanks! one complaining comment below, up to you what to do with it if you
think git cl format did ok job there ;)

lgtm

https://codereview.chromium.org/2674613003/diff/40001/device/sensors/sensor_m...
File device/sensors/sensor_manager_android.cc (right):

https://codereview.chromium.org/2674613003/diff/40001/device/sensors/sensor_m...
device/sensors/sensor_manager_android.cc:334: received_motion_data_
yah this one is also weird, I guess the original was a bit more readable..

[ke.he, 2017-02-17 02:35:45]

On 2017/02/16 23:31:02, timvolodine wrote:
> okay thanks! one complaining comment below, up to you what to do with it if
you
> think git cl format did ok job there ;)
> 
> lgtm
> 
>
https://codereview.chromium.org/2674613003/diff/40001/device/sensors/sensor_m...
> File device/sensors/sensor_manager_android.cc (right):
> 
>
https://codereview.chromium.org/2674613003/diff/40001/device/sensors/sensor_m...
> device/sensors/sensor_manager_android.cc:334: received_motion_data_
> yah this one is also weird, I guess the original was a bit more readable..

Thanks :)

[ke.he, 2017-02-17 02:35:53]

The CQ bit was checked by ke.he@intel.com

[commit-bot: I haz the power, 2017-02-17 02:36:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 04:28:51]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487298953824320,
"parent_rev": "9c3ce4099b593b5172fe94028c949730f72716ef", "commit_rev":
"f6fb3e420e012be507b027e747dc819d7fb4da73"}

[commit-bot: I haz the power, 2017-02-17 04:29:55]

Description was changed from

==========
git cl format //device/sensors

After we moved the //content/browser/device_sensors to //device/sensors,
we use this separate CL to do "git cl formatting".
The log tag "cr.sensors" is changed into "sensors" in DeviceSensors.java to
eliminates the presubmit warnings.

BUG=612322
==========

to

==========
git cl format //device/sensors

After we moved the //content/browser/device_sensors to //device/sensors,
we use this separate CL to do "git cl formatting".
The log tag "cr.sensors" is changed into "sensors" in DeviceSensors.java to
eliminates the presubmit warnings.

BUG=612322

Review-Url: https://codereview.chromium.org/2674613003
Cr-Commit-Position: refs/heads/master@{#451208}
Committed:
https://chromium.googlesource.com/chromium/src/+/f6fb3e420e012be507b027e747dc...
==========

[commit-bot: I haz the power, 2017-02-17 04:29:57]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f6fb3e420e012be507b027e747dc...