Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2674613002: Improve ValueSerializer perf regression after 96635558 (Closed)

Created:
3 years, 10 months ago by binji
Modified:
3 years, 10 months ago
Reviewers:
jbroman, Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Improve ValueSerializer perf regression after 96635558 BUG=687196 R=jbroman@chromium.org Review-Url: https://codereview.chromium.org/2674613002 Cr-Commit-Position: refs/heads/master@{#42938} Committed: https://chromium.googlesource.com/v8/v8/+/79837f5f6f269cf3579b10d403396b742786fcff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/value-serializer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
binji
This seemed to help quite a bit testing on linux-rel. Haven't tested on ARM, so ...
3 years, 10 months ago (2017-02-02 02:12:13 UTC) #1
jbroman
lgtm
3 years, 10 months ago (2017-02-02 18:30:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674613002/1
3 years, 10 months ago (2017-02-02 20:21:30 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-02 20:21:32 UTC) #10
Camillo Bruni
lgtm
3 years, 10 months ago (2017-02-03 22:03:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674613002/1
3 years, 10 months ago (2017-02-04 00:17:43 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-04 00:44:54 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/79837f5f6f269cf3579b10d403396b74278...

Powered by Google App Engine
This is Rietveld 408576698