Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2674573011: [DIAL] Break circular dependency in DialFetchDeviceDescriptionFunction. (Closed)

Created:
3 years, 10 months ago by imcheng
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[DIAL] Break circular dependency in DialFetchDeviceDescriptionFunction. DeviceDescriptionFetcher has 2 references (in the 2 calbacks) to the DialFetchDeviceDescriptionFunction that owns it, but only 1 of the 2 references is removed at the end state. This results in a circular dependency which prevents the function from being destroyed. This patch manually destroys the DeviceDescriptionFetcher after the fetching is done to break the circular dependency. BUG=688089 Review-Url: https://codereview.chromium.org/2668383004 Cr-Commit-Position: refs/heads/master@{#447857} (cherry picked from commit d8033dadec98c7c2f4c407f89c128b166b5922ef) Review-Url: https://codereview.chromium.org/2674573011 . Cr-Commit-Position: refs/branch-heads/2987@{#304} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/b656c780b62f5bca1465324360c2be28ee73deca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/extensions/api/dial/dial_api.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
imcheng
3 years, 10 months ago (2017-02-03 22:48:42 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b656c780b62f5bca1465324360c2be28ee73deca.

Powered by Google App Engine
This is Rietveld 408576698