Upstream Link: rel=serviceworker tests.

Upstream Link: rel=serviceworker tests.

BUG=688116
Review-Url: https://codereview.chromium.org/2674573004
Cr-Commit-Position: refs/heads/master@{#448683}
Committed: https://chromium.googlesource.com/chromium/src/+/54675ad03dc978e465a86951062c35863e6a1f32

[Marijn Kruisselbrink, 2017-02-02 20:06:02]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 20:06:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marijn Kruisselbrink, 2017-02-02 20:24:34]

mek@chromium.org changed reviewers:
+ falken@chromium.org

[Marijn Kruisselbrink, 2017-02-02 21:29:05]

Description was changed from

==========
Upstream Link: rel=serviceworker tests.

BUG=None
==========

to

==========
Upstream Link: rel=serviceworker tests.

BUG=688116
==========

[commit-bot: I haz the power, 2017-02-02 22:03:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 22:03:14]

Dry run: This issue passed the CQ dry run.

[falken, 2017-02-04 00:35:01]

On 2017/02/02 20:24:35, Marijn Kruisselbrink wrote:

Sorry I overestimated the time I had this week. I might not get to this until
next week.

[Marijn Kruisselbrink, 2017-02-04 00:43:29]

On 2017/02/04 at 00:35:01, falken wrote:
> On 2017/02/02 20:24:35, Marijn Kruisselbrink wrote:
> 
> Sorry I overestimated the time I had this week. I might not get to this until
next week.

No problem. I'm not in any hurry.

[falken, 2017-02-07 01:42:32]

lgtm, nice.

https://codereview.chromium.org/2674573004/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json (left):

https://codereview.chromium.org/2674573004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json:34328: -  ],
Just checking, the FileAPI changes in this file are intentional right? Is this
file auto-updated or something?

[Marijn Kruisselbrink, 2017-02-07 17:54:12]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 17:54:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marijn Kruisselbrink, 2017-02-07 17:59:55]

https://codereview.chromium.org/2674573004/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json (left):

https://codereview.chromium.org/2674573004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json:34328: -  ],
On 2017/02/07 at 01:42:32, falken wrote:
> Just checking, the FileAPI changes in this file are intentional right? Is this
file auto-updated or something?

This file is auto-updated by running a script, yes. And it seems that the way
people are told to run the script when adding new tests does not entirely match
the way the script is run when tests are imported, resulting in (irrelevant)
changes in the file. I think the ultimate goal is to not check in the generated
file at all.

[Marijn Kruisselbrink, 2017-02-07 18:46:36]

The CQ bit was unchecked by mek@chromium.org

[Marijn Kruisselbrink, 2017-02-07 18:46:40]

The CQ bit was checked by mek@chromium.org

[Marijn Kruisselbrink, 2017-02-07 18:46:40]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/2674573004/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-07 18:46:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 19:03:59]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486493200651260,
"parent_rev": "56c49db6fa925b9190d362d2a3d1207f7194242d", "commit_rev":
"54675ad03dc978e465a86951062c35863e6a1f32"}

[commit-bot: I haz the power, 2017-02-07 19:04:34]

Description was changed from

==========
Upstream Link: rel=serviceworker tests.

BUG=688116
==========

to

==========
Upstream Link: rel=serviceworker tests.

BUG=688116

Review-Url: https://codereview.chromium.org/2674573004
Cr-Commit-Position: refs/heads/master@{#448683}
Committed:
https://chromium.googlesource.com/chromium/src/+/54675ad03dc978e465a86951062c...
==========

[commit-bot: I haz the power, 2017-02-07 19:04:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/54675ad03dc978e465a86951062c...