Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2674533002: [Contextual Search] Only record duration between trigger and scroll for taps (Closed)

Created:
3 years, 10 months ago by Theresa
Modified:
3 years, 10 months ago
CC:
chromium-reviews, twellington+watch_chromium.org, mdjones+watch_chromium.org, donnd+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Contextual Search] Only record duration between trigger and scroll for taps BUG=687741 Review-Url: https://codereview.chromium.org/2674533002 Cr-Commit-Position: refs/heads/master@{#447942} Committed: https://chromium.googlesource.com/chromium/src/+/f337befaca3a6db9ec08a180cf85a0630aba611c

Patch Set 1 #

Patch Set 2 : Update histograms.xml #

Messages

Total messages: 19 (13 generated)
Theresa
ptal
3 years, 10 months ago (2017-02-01 23:44:15 UTC) #4
Donn Denman
LGTM except for histograms.xml. I think we need to update the histogram descriptions to specify ...
3 years, 10 months ago (2017-02-02 00:26:59 UTC) #5
Theresa
+holte@ for histograms.xml
3 years, 10 months ago (2017-02-02 00:39:08 UTC) #8
Steven Holte
histograms lgtm
3 years, 10 months ago (2017-02-03 02:52:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674533002/20001
3 years, 10 months ago (2017-02-03 02:55:57 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 04:51:47 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f337befaca3a6db9ec08a180cf85...

Powered by Google App Engine
This is Rietveld 408576698