Unit tests for WebStateObserverBridge class.

Unit tests for WebStateObserverBridge class.

BUG=685397
Review-Url: https://codereview.chromium.org/2674503002
Cr-Commit-Position: refs/heads/master@{#448131}
Committed: https://chromium.googlesource.com/chromium/src/+/90396e6b910b9e4e9604074274d21ac0df14831f

[Eugene But (OOO till 7-30), 2017-02-01 23:15:01]

eugenebut@chromium.org changed reviewers:
+ marq@chromium.org

[Eugene But (OOO till 7-30), 2017-02-01 23:15:09]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 23:15:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 00:46:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 00:46:20]

Dry run: This issue passed the CQ dry run.

[marq (ping after 24h), 2017-02-02 17:59:26]

LGTM with probably painful naming suggestion.

https://codereview.chromium.org/2674503002/diff/1/ios/web/public/test/fakes/c...
File ios/web/public/test/fakes/crw_test_web_state_observer.h (right):

https://codereview.chromium.org/2674503002/diff/1/ios/web/public/test/fakes/c...
ios/web/public/test/fakes/crw_test_web_state_observer.h:16: struct
TestStartProvisionalNavigationInfo {
Naming: should all of the indentifiers s/Test/Fake/ for clarity?

(In general I think it's better to reserve 'Test' for the names of test
fixtures, and to clarify whether test object are fakes, mocks, or stubs)

[Eugene But (OOO till 7-30), 2017-02-02 18:24:26]

Thanks! Are you ok with doing cleanup in a separate CL? Test prefix is kinda
consistent, though I agree that it's not very good one :)

https://codereview.chromium.org/2674503002/diff/1/ios/web/public/test/fakes/c...
File ios/web/public/test/fakes/crw_test_web_state_observer.h (right):

https://codereview.chromium.org/2674503002/diff/1/ios/web/public/test/fakes/c...
ios/web/public/test/fakes/crw_test_web_state_observer.h:16: struct
TestStartProvisionalNavigationInfo {
On 2017/02/02 17:59:25, marq wrote:
> Naming: should all of the indentifiers s/Test/Fake/ for clarity?
> 
> (In general I think it's better to reserve 'Test' for the names of test
> fixtures, and to clarify whether test object are fakes, mocks, or stubs)
We have bunch of existing fakes prefixed as Test, so I think if we fix them we
should fix them altogether as a separate effort. Filed crbug.com/688063 to
address that.

[Eugene But (OOO till 7-30), 2017-02-03 23:43:28]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-02-03 23:44:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 00:52:23]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486165408744160, "parent_rev":
"da6bfa38a01d5bda51eb7ae4f5382726dd4ac668", "commit_rev":
"90396e6b910b9e4e9604074274d21ac0df14831f"}

[commit-bot: I haz the power, 2017-02-04 00:52:53]

Description was changed from

==========
Unit tests for WebStateObserverBridge class.

BUG=685397
==========

to

==========
Unit tests for WebStateObserverBridge class.

BUG=685397

Review-Url: https://codereview.chromium.org/2674503002
Cr-Commit-Position: refs/heads/master@{#448131}
Committed:
https://chromium.googlesource.com/chromium/src/+/90396e6b910b9e4e9604074274d2...
==========

[commit-bot: I haz the power, 2017-02-04 00:52:55]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/90396e6b910b9e4e9604074274d2...