Issue 2674493004: Implement Search.classMembers() using getFilesDefiningClassMemberName().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2674493004: Implement Search.classMembers() using getFilesDefiningClassMemberName(). (Closed)

Created:
3 years, 10 months ago by scheglov

Modified:
3 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Implement Search.classMembers() using getFilesDefiningClassMemberName(). This fixes the performance problem you saw on class renames. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/69f9f781ccb85beda5132ea12b7cc2fd3c4b0937

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -25 lines)			Patch
M	pkg/analysis_server/lib/src/services/search/search_engine_internal2.dart	View	3 chunks	+14 lines, -15 lines	0 comments	Download
M	pkg/analyzer/lib/src/dart/analysis/search.dart	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	pkg/analyzer/test/src/dart/analysis/search_test.dart	View	2 chunks	+2 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 10 months ago (2017-02-02 18:48:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
69f9f781ccb85beda5132ea12b7cc2fd3c4b0937 (presubmit successful).