Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: pkg/analysis_server/lib/src/services/search/search_engine_internal2.dart

Issue 2674493004: Implement Search.classMembers() using getFilesDefiningClassMemberName(). (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/dart/analysis/search.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/services/search/search_engine_internal2.dart
diff --git a/pkg/analysis_server/lib/src/services/search/search_engine_internal2.dart b/pkg/analysis_server/lib/src/services/search/search_engine_internal2.dart
index e14a6ac87a6bba917908297c24ed141afefd2f70..d9088a9d9d3c2aa98ca52cdd8facd8c42f0c6ebe 100644
--- a/pkg/analysis_server/lib/src/services/search/search_engine_internal2.dart
+++ b/pkg/analysis_server/lib/src/services/search/search_engine_internal2.dart
@@ -39,9 +39,8 @@ class SearchEngineImpl2 implements SearchEngine {
@override
Future<List<SearchMatch>> searchMemberDeclarations(String name) async {
List<SearchMatch> allDeclarations = [];
- RegExp regExp = new RegExp('^$name\$');
for (AnalysisDriver driver in _drivers) {
- List<Element> elements = await driver.search.classMembers(regExp);
+ List<Element> elements = await driver.search.classMembers(name);
allDeclarations.addAll(elements.map(_SearchMatch.forElement));
}
return allDeclarations;
@@ -153,6 +152,19 @@ class _SearchMatch implements SearchMatch {
return buffer.toString();
}
+ static _SearchMatch forElement(Element element) {
+ return new _SearchMatch(
+ element.source.fullName,
+ element.librarySource,
+ element.source,
+ element.library,
+ element,
+ true,
+ true,
+ MatchKind.DECLARATION,
+ new SourceRange(element.nameOffset, element.nameLength));
+ }
+
static _SearchMatch forSearchResult(SearchResult result) {
Element enclosingElement = result.enclosingElement;
return new _SearchMatch(
@@ -167,19 +179,6 @@ class _SearchMatch implements SearchMatch {
new SourceRange(result.offset, result.length));
}
- static _SearchMatch forElement(Element element) {
- return new _SearchMatch(
- element.source.fullName,
- element.librarySource,
- element.source,
- element.library,
- element,
- true,
- true,
- MatchKind.DECLARATION,
- new SourceRange(element.nameOffset, element.nameLength));
- }
-
static MatchKind toMatchKind(SearchResultKind kind) {
if (kind == SearchResultKind.READ) {
return MatchKind.READ;
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/dart/analysis/search.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698