Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2674493002:
[heap] Refactor AllocatedSinceLastGC (Closed)
|
Created:
3 years, 10 months ago by Michael Lippautz Modified:
3 years, 10 months ago Reviewers:
Hannes Payer (out of office) CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[heap] Refactor AllocatedSinceLastGC
Remove the cases that deal with a top pointer that is reset. We should always
be in a sane state wrt. top and age mark. Also add more DCHECKs.
BUG=chromium:672678
Review-Url: https://codereview.chromium.org/2674493002
Cr-Commit-Position: refs/heads/master@{#42873}
Committed: https://chromium.googlesource.com/v8/v8/+/70a31eeb4abbc76005077f76812c71bc9aba38cc
Patch Set 1 #
Messages
Total messages: 23 (19 generated)
Patchset #1 (id:1) has been deleted
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [heap] Refactor AllocatedSinceLastGC BUG= ========== to ========== [heap] Refactor AllocatedSinceLastGC BUG=chromium:672678 ==========
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [heap] Refactor AllocatedSinceLastGC BUG=chromium:672678 ========== to ========== [heap] Refactor AllocatedSinceLastGC Remove the cases that deal with a top pointer that is reset. We should always be in a sane state wrt. top and age mark. Also add more DCHECKs. BUG=chromium:672678 ==========
Description was changed from ========== [heap] Refactor AllocatedSinceLastGC Remove the cases that deal with a top pointer that is reset. We should always be in a sane state wrt. top and age mark. Also add more DCHECKs. BUG=chromium:672678 ========== to ========== [heap] Refactor AllocatedSinceLastGC Remove the cases that deal with a top pointer that is reset. We should always be in a sane state wrt. top and age mark. Also add more DCHECKs. BUG=chromium:672678 ==========
Description was changed from ========== [heap] Refactor AllocatedSinceLastGC Remove the cases that deal with a top pointer that is reset. We should always be in a sane state wrt. top and age mark. Also add more DCHECKs. BUG=chromium:672678 ========== to ========== [heap] Refactor AllocatedSinceLastGC Remove the cases that deal with a top pointer that is reset. We should always be in a sane state wrt. top and age mark. Also add more DCHECKs. BUG=chromium:672678 ==========
mlippautz@chromium.org changed reviewers: + hpayer@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by mlippautz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485994330345930,
"parent_rev": "591cc0b4ccdb6934d76ea163569b5194faef4dcf", "commit_rev":
"70a31eeb4abbc76005077f76812c71bc9aba38cc"}
Message was sent while issue was closed.
Description was changed from ========== [heap] Refactor AllocatedSinceLastGC Remove the cases that deal with a top pointer that is reset. We should always be in a sane state wrt. top and age mark. Also add more DCHECKs. BUG=chromium:672678 ========== to ========== [heap] Refactor AllocatedSinceLastGC Remove the cases that deal with a top pointer that is reset. We should always be in a sane state wrt. top and age mark. Also add more DCHECKs. BUG=chromium:672678 Review-Url: https://codereview.chromium.org/2674493002 Cr-Commit-Position: refs/heads/master@{#42873} Committed: https://chromium.googlesource.com/v8/v8/+/70a31eeb4abbc76005077f76812c71bc9ab... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:60001) as https://chromium.googlesource.com/v8/v8/+/70a31eeb4abbc76005077f76812c71bc9ab... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
