Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 2674473002: Fix context menu web shell EarlGrey tests. (Closed)

Created:
3 years, 10 months ago by baxley
Modified:
3 years, 10 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix context menu web shell EarlGrey tests. Verify links are visible on the webview before trying to long press them. Enables testContextMenu. BUG=687546 Review-Url: https://codereview.chromium.org/2674473002 Cr-Commit-Position: refs/heads/master@{#447638} Committed: https://chromium.googlesource.com/chromium/src/+/5ea36c973a46c98262c61b5e1d7c8dd86038c857

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -13 lines) Patch
M ios/web/shell/test/context_menu_egtest.mm View 5 chunks +21 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
baxley
3 years, 10 months ago (2017-02-01 22:15:36 UTC) #2
Eugene But (OOO till 7-30)
lgtm
3 years, 10 months ago (2017-02-01 22:31:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674473002/1
3 years, 10 months ago (2017-02-01 23:03:43 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 23:15:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5ea36c973a46c98262c61b5e1d7c...

Powered by Google App Engine
This is Rietveld 408576698