Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 2674453002: DevTools: Properly restore focus after tabbing through inplace editors (Closed)

Created:
3 years, 10 months ago by einbinder
Modified:
3 years, 10 months ago
Reviewers:
dgozman, pfeldman1, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Properly restore focus after tabbing through inplace editors Pressing tab while editing an attribute would first move the focus, and then start editing the next attribute. After editing finished, focus would be restored to the wrong place. BUG=none Review-Url: https://codereview.chromium.org/2674453002 Cr-Commit-Position: refs/heads/master@{#447865} Committed: https://chromium.googlesource.com/chromium/src/+/b21c8f416727d8fc6e9d4cc303bf733ab35a5559

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/InplaceEditor.js View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
einbinder
ptal
3 years, 10 months ago (2017-02-01 21:40:23 UTC) #2
pfeldman1
Please test it well manually
3 years, 10 months ago (2017-02-01 22:54:54 UTC) #4
pfeldman1
lgtm
3 years, 10 months ago (2017-02-01 22:55:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674453002/1
3 years, 10 months ago (2017-02-02 06:20:59 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-02 06:21:01 UTC) #9
einbinder
@pfeldman, can you lgtm from your chromium account?
3 years, 10 months ago (2017-02-02 18:52:03 UTC) #10
pfeldman
lgtm
3 years, 10 months ago (2017-02-02 19:07:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674453002/1
3 years, 10 months ago (2017-02-02 20:38:03 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 22:46:23 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b21c8f416727d8fc6e9d4cc303bf...

Powered by Google App Engine
This is Rietveld 408576698