Issue 2674433002: [Mac] Zoom Bubble Autoclosing Fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2674433002: [Mac] Zoom Bubble Autoclosing Fix (Closed)

Created:
3 years, 10 months ago by spqchan

Modified:
3 years, 10 months ago

Reviewers:

CC:
chromium-reviews, mac-reviews_chromium.org

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Mac] Zoom Bubble Autoclosing Fix With the new MD style the zoom bubble should autoclose, even if the zoom decoration is pressed. Since the bubble isn't actually pointing to the decoration, it should not stay opened, even when the the decoration is pressed. BUG=682168 Review-Url: https://codereview.chromium.org/2652893007 Cr-Commit-Position: refs/heads/master@{#446378} (cherry picked from commit ce00d1fcc3a2779d4db9771ca35513a416de9f9d)

Patch Set 1 #

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

spqchan

3 years, 10 months ago (2017-02-01 20:59:08 UTC) #1

Description was changed from

==========
[Mac] Zoom Bubble Autoclosing Fix

With the new MD style the zoom bubble should autoclose, even if the
zoom decoration is pressed. Since the bubble isn't actually pointing
to the decoration, it should not stay opened, even when the the
decoration is pressed.

BUG=682168

Review-Url: https://codereview.chromium.org/2652893007
Cr-Commit-Position: refs/heads/master@{#446378}
(cherry picked from commit ce00d1fcc3a2779d4db9771ca35513a416de9f9d)
==========

to

==========
[Mac] Zoom Bubble Autoclosing Fix

With the new MD style the zoom bubble should autoclose, even if the
zoom decoration is pressed. Since the bubble isn't actually pointing
to the decoration, it should not stay opened, even when the the
decoration is pressed.

BUG=682168

Review-Url: https://codereview.chromium.org/2652893007
Cr-Commit-Position: refs/heads/master@{#446378}
(cherry picked from commit ce00d1fcc3a2779d4db9771ca35513a416de9f9d)
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages