Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2652893007: [Mac] Zoom Bubble Autoclosing Fix (Closed)

Created:
3 years, 11 months ago by spqchan
Modified:
3 years, 10 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Zoom Bubble Autoclosing Fix With the new MD style the zoom bubble should autoclose, even if the zoom decoration is pressed. Since the bubble isn't actually pointing to the decoration, it should not stay opened, even when the the decoration is pressed. BUG=682168 Review-Url: https://codereview.chromium.org/2652893007 Cr-Commit-Position: refs/heads/master@{#446378} Committed: https://chromium.googlesource.com/chromium/src/+/ce00d1fcc3a2779d4db9771ca35513a416de9f9d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
spqchan
PTAL
3 years, 11 months ago (2017-01-25 19:01:30 UTC) #8
Robert Sesek
lgtm
3 years, 11 months ago (2017-01-26 12:34:53 UTC) #9
spqchan
On 2017/01/26 12:34:53, Robert Sesek wrote: > lgtm thanks!
3 years, 10 months ago (2017-01-26 17:50:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652893007/1
3 years, 10 months ago (2017-01-26 17:51:03 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-01-26 18:22:01 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ce00d1fcc3a2779d4db9771ca355...

Powered by Google App Engine
This is Rietveld 408576698