Issue 2674393002: Read NQE prefs to network quality store under all cases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2674393002: Read NQE prefs to network quality store under all cases (Closed)

Created:
3 years, 10 months ago by tbansal1

Modified:
3 years, 10 months ago

Reviewers:

CC:
chromium-reviews, cbentzel+watch_chromium.org, tbansal+watch-nqe_chromium.org

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

More Reviews

Description

Read NQE prefs to network quality store under all cases In Network Quality Estimator (NQE), change the logic to read the prefs even if caching is not enabled via finch trial. If the caching is disabled, the network quality store is not queried by NQE. BUG=688121 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2672733002 Cr-Commit-Position: refs/heads/master@{#448118} (cherry picked from commit 4ff2bf0b92b736c30c01f584ee41fd10f19f63a8)

Patch Set 1 #

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+204 lines, -67 lines)			Patch
M	chrome/browser/net/nqe/ui_network_quality_estimator_service.cc	View	3 chunks	+0 lines, -39 lines	0 comments	Download
M	chrome/browser/net/nqe/ui_network_quality_estimator_service_browsertest.cc	View	5 chunks	+7 lines, -26 lines	0 comments	Download
M	net/nqe/network_quality_estimator.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	net/nqe/network_quality_estimator.cc	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	net/nqe/network_quality_estimator_params.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	net/nqe/network_quality_estimator_params.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	net/nqe/network_quality_estimator_unittest.cc	View	5 chunks	+169 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

tbansal1

3 years, 10 months ago (2017-02-06 19:21:04 UTC) #1

Description was changed from

==========
Read NQE prefs to network quality store under all cases

In Network Quality Estimator (NQE), change the logic to read the
prefs even if caching is not enabled via finch trial. If the caching
is  disabled, the network quality store is not queried by NQE.

BUG=688121
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2672733002
Cr-Commit-Position: refs/heads/master@{#448118}
(cherry picked from commit 4ff2bf0b92b736c30c01f584ee41fd10f19f63a8)
==========

to

==========
Read NQE prefs to network quality store under all cases

In Network Quality Estimator (NQE), change the logic to read the
prefs even if caching is not enabled via finch trial. If the caching
is  disabled, the network quality store is not queried by NQE.

BUG=688121
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2672733002
Cr-Commit-Position: refs/heads/master@{#448118}
(cherry picked from commit 4ff2bf0b92b736c30c01f584ee41fd10f19f63a8)
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages