Read NQE prefs to network quality store under all cases

Read NQE prefs to network quality store under all cases

In Network Quality Estimator (NQE), change the logic to read the
prefs even if caching is not enabled via finch trial. If the caching
is  disabled, the network quality store is not queried by NQE.

BUG=688121
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2672733002
Cr-Commit-Position: refs/heads/master@{#448118}
Committed: https://chromium.googlesource.com/chromium/src/+/4ff2bf0b92b736c30c01f584ee41fd10f19f63a8

[tbansal1, 2017-02-02 08:47:48]

Description was changed from

==========
NQE Prefs

BUG=
==========

to

==========
NQE Prefs

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2017-02-02 08:47:55]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 08:47:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 10:47:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 10:47:53]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2017-02-02 21:34:44]

Description was changed from

==========
NQE Prefs

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Read NQE prefs to network quality store under all cases

In Network Quality Estimator (NQE), change the logic to read the
prefs even if caching is not enabled via finch trial. If the caching
is  disabled, the network quality store is not queried by NQE.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2017-02-02 21:38:35]

Description was changed from

==========
Read NQE prefs to network quality store under all cases

In Network Quality Estimator (NQE), change the logic to read the
prefs even if caching is not enabled via finch trial. If the caching
is  disabled, the network quality store is not queried by NQE.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Read NQE prefs to network quality store under all cases

In Network Quality Estimator (NQE), change the logic to read the
prefs even if caching is not enabled via finch trial. If the caching
is  disabled, the network quality store is not queried by NQE.

BUG=688121
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2017-02-02 22:01:50]

Patchset #2 (id:20001) has been deleted

[tbansal1, 2017-02-02 22:05:08]

Patchset #1 (id:1) has been deleted

[tbansal1, 2017-02-02 22:05:15]

Patchset #1 (id:40001) has been deleted

[tbansal1, 2017-02-02 22:05:32]

tbansal@chromium.org changed reviewers:
+ ryansturm@chromium.org

[tbansal1, 2017-02-02 22:05:32]

ryansturm: ptal. Thanks.

[tbansal1, 2017-02-02 22:05:39]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 22:06:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 23:47:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 23:47:45]

Dry run: This issue passed the CQ dry run.

[RyanSturm, 2017-02-03 18:25:58]

lgtm. What prompted always writing to the cache?

[tbansal1, 2017-02-03 18:28:11]

On 2017/02/03 18:25:58, Ryan Sturm wrote:
> lgtm. What prompted always writing to the cache?

Well, we still want to write to cache even if reading
is disabled. This enables NQE to build up the history,
and use it next time if it happens to fall in the 
field trial group in which reading of prefs is
enabled.

[tbansal1, 2017-02-03 22:16:10]

The CQ bit was checked by tbansal@chromium.org

[commit-bot: I haz the power, 2017-02-03 22:17:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 00:35:54]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486160170665010,
"parent_rev": "1376441968238eda09707a4f185c6727f3bed482", "commit_rev":
"4ff2bf0b92b736c30c01f584ee41fd10f19f63a8"}

[commit-bot: I haz the power, 2017-02-04 00:36:35]

Description was changed from

==========
Read NQE prefs to network quality store under all cases

In Network Quality Estimator (NQE), change the logic to read the
prefs even if caching is not enabled via finch trial. If the caching
is  disabled, the network quality store is not queried by NQE.

BUG=688121
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Read NQE prefs to network quality store under all cases

In Network Quality Estimator (NQE), change the logic to read the
prefs even if caching is not enabled via finch trial. If the caching
is  disabled, the network quality store is not queried by NQE.

BUG=688121
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2672733002
Cr-Commit-Position: refs/heads/master@{#448118}
Committed:
https://chromium.googlesource.com/chromium/src/+/4ff2bf0b92b736c30c01f584ee41...
==========

[commit-bot: I haz the power, 2017-02-04 00:36:36]

Committed patchset #1 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/4ff2bf0b92b736c30c01f584ee41...