content: Allow printing stack-trace when browser process crashes.

content: Allow printing stack-trace when browser process crashes.

browser-process currently leaves a stacktrace when a CHECK() is tripped,
but leaves no trace if it crashes for some other reason (e.g. illegal
operation, segfault etc.). This change makes sure crashes from these
in the browser process also leave a backtrace.

BUG=none

Review-Url: https://codereview.chromium.org/2674373003
Cr-Commit-Position: refs/heads/master@{#449034}
Committed: https://chromium.googlesource.com/chromium/src/+/f6fb2a71b8b6c25094720ab815204250d2debb00

[sadrul, 2017-02-07 03:01:49]

sadrul@chromium.org changed reviewers:
+ jam@chromium.org

[sadrul, 2017-02-07 03:07:52]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 03:08:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-02-07 03:10:28]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 03:10:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 05:02:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 05:02:49]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[James Cook, 2017-02-07 15:26:45]

jamescook@chromium.org changed reviewers:
+ jamescook@chromium.org

[James Cook, 2017-02-07 15:26:45]

drive-by LGTM. This is good from a Chrome OS crash reporting perspective. In
particular, the old code would call breakpad::InitCrashReporter() in
ChromeMainDelegate *before* EnableInProcessStackDumping(), which on non-official
builds was probably breaking crash reporting. (That would only break it for
developers, of course.) This seems to put things in the right order.

[James Cook, 2017-02-07 15:27:51]

On 2017/02/07 15:26:45, James Cook wrote:
> drive-by LGTM. This is good from a Chrome OS crash reporting perspective. In
> particular, the old code would call breakpad::InitCrashReporter() in
> ChromeMainDelegate *before* EnableInProcessStackDumping(), which on
non-official
> builds was probably breaking crash reporting. (That would only break it for
> developers, of course.) This seems to put things in the right order.

(Forgot to mention: EnableInProcessStackDumping on Linux overwrites signal
handlers that breakpad::InitCrashReporter installs, whereas breakpad is smart
enough to call existing signal handlers if it is initialized second.)

[jam, 2017-02-07 17:45:11]

lgtm

[jam, 2017-02-07 17:45:43]

On 2017/02/07 17:45:11, jam wrote:
> lgtm

although this seems to break ContentBrowserTest.RendererCrashCallStack?

[sadrul, 2017-02-08 01:38:21]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 01:38:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-02-08 01:39:13]

On 2017/02/07 17:45:43, jam wrote:
> On 2017/02/07 17:45:11, jam wrote:
> > lgtm
> 
> although this seems to break ContentBrowserTest.RendererCrashCallStack?

Yep. I have fixed that in the latest patchset. Mind taking another look? Thanks!

[commit-bot: I haz the power, 2017-02-08 03:13:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 03:13:23]

Dry run: This issue passed the CQ dry run.

[jam, 2017-02-08 17:06:23]

lgtm

[sadrul, 2017-02-08 17:54:17]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2017-02-08 17:54:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2674373003/#ps40001
(title: ".")

[commit-bot: I haz the power, 2017-02-08 17:54:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 17:59:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486576457305120,
"parent_rev": "9c873d8cc8d88b07459b488af5d2da479e5c3acc", "commit_rev":
"f6fb2a71b8b6c25094720ab815204250d2debb00"}

[commit-bot: I haz the power, 2017-02-08 18:00:05]

Description was changed from

==========
content: Allow printing stack-trace when browser process crashes.

browser-process currently leaves a stacktrace when a CHECK() is tripped,
but leaves no trace if it crashes for some other reason (e.g. illegal
operation, segfault etc.). This change makes sure crashes from these
in the browser process also leave a backtrace.

BUG=none
==========

to

==========
content: Allow printing stack-trace when browser process crashes.

browser-process currently leaves a stacktrace when a CHECK() is tripped,
but leaves no trace if it crashes for some other reason (e.g. illegal
operation, segfault etc.). This change makes sure crashes from these
in the browser process also leave a backtrace.

BUG=none

Review-Url: https://codereview.chromium.org/2674373003
Cr-Commit-Position: refs/heads/master@{#449034}
Committed:
https://chromium.googlesource.com/chromium/src/+/f6fb2a71b8b6c25094720ab81520...
==========

[commit-bot: I haz the power, 2017-02-08 18:00:09]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f6fb2a71b8b6c25094720ab81520...