Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 2674283002: Make metrics pretty_print.py scripts runnable from git cl format. (Closed)

Created:
3 years, 10 months ago by Alexei Svitkine (slow)
Modified:
3 years, 10 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make metrics pretty_print.py scripts runnable from git cl format. Adds some additional command-line params to metrics (histograms, actions, rappor) pretty_print.py scripts that format XML files so that they can be invoked by 'git cl format'. This will allow (in a follow-up CL to depot tools) to have git cl format invoke these scripts automatically when ran. BUG=679514 Review-Url: https://codereview.chromium.org/2674283002 Cr-Commit-Position: refs/heads/master@{#448292} Committed: https://chromium.googlesource.com/chromium/src/+/02441ca994699e2ce6fe29247a4f97970899c721

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M tools/metrics/common/presubmit_util.py View 3 chunks +21 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Alexei Svitkine (slow)
3 years, 10 months ago (2017-02-06 15:41:03 UTC) #2
Ilya Sherman
LGTM, thanks.
3 years, 10 months ago (2017-02-06 17:21:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674283002/1
3 years, 10 months ago (2017-02-06 17:22:28 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 17:46:27 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/02441ca994699e2ce6fe29247a4f...

Powered by Google App Engine
This is Rietveld 408576698