Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2674273003: Revert of [Presentation API] (5th) (1-UA) integrate controller and receiver side for 1-UA messaging (Closed)

Created:
3 years, 10 months ago by joedow
Modified:
3 years, 10 months ago
CC:
Aaron Boodman, abarth-chromium, blink-reviews, blink-reviews-api_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, dglazkov+blink, extensions-reviews_chromium.org, jam, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, takumif, viettrungluu+watch_chromium.org, xjz+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Presentation API] (5th) (1-UA) integrate controller and receiver side for 1-UA messaging (patchset #16 id:400001 of https://codereview.chromium.org/2471573005/ ) Reason for revert: Reverting as this is a suspect CL causing a presentation webkit test to fail: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/22948 Debug output: 10:33:07.330 27811 renderer crash, pid = None, error_line = #CRASHED - renderer 10:33:07.331 27811 killed pid 18285 10:33:07.331 27811 worker/2 presentation/presentation-reconnect.html crashed, (stderr lines): 10:33:07.332 27811 [18285:18329:0206/103306.890280:1569541808:WARNING:url_request_job_manager.cc(90)] Failed to map: layout-test-mojom://content/shell/renderer/layout_test/frame_interface_registry 10:33:07.332 27811 [18285:18329:0206/103306.890393:1569541918:WARNING:url_request_job_manager.cc(90)] Failed to map: layout-test-mojom://content/shell/renderer/layout_test/interface_registry 10:33:07.332 27811 [18285:18329:0206/103306.891027:1569542552:WARNING:url_request_job_manager.cc(90)] Failed to map: layout-test-mojom://Mojo Helpers 10:33:07.332 27811 [1:1:0206/103306.896454:1569552070:ERROR:mojo_context_state.cc(194)] Failed to fetch source for module "content/shell/renderer/layout_test/frame_interface_registry" 10:33:07.332 27811 [1:1:0206/103306.900643:1569552511:ERROR:mojo_context_state.cc(194)] Failed to fetch source for module "content/shell/renderer/layout_test/interface_registry" 10:33:07.332 27811 [1:1:0206/103306.901223:1569553276:ERROR:mojo_context_state.cc(194)] Failed to fetch source for module "Mojo Helpers" 10:33:07.332 27811 [18285:18329:0206/103306.932287:1569583816:WARNING:crash_handler_host_linux.cc(324)] Could not translate tid, attempt = 1 retry ... 10:33:07.333 27725 [42777/48739] presentation/presentation-reconnect.html failed unexpectedly (renderer crashed) Original issue's description: > [Presentation API] (5th)(1-UA) integrate controller and receiver side for 1-UA messaging > > This CL actually turns on 1-UA messaging: > > - When presentation starts, a new route is created and returned to MR. In PresentationDispatcher, we send controller_connection_proxy and receiver_connection_request back to browser via PresentationService::SetPresentationConnection() > > For 1-UA: > - In PresentationServiceDelegateImpl::ConnectToPresentation(), we register proxy and request as a controller connection entry to OPM. If there has been a receiver_call_back, invoke it; > - When offscreen tab is rendered, we register a receiverPSDImpl, which registers a receiver_call_back to OPM. If there is any pending controller connection entry, invoke receiver_call_back for each controller connection entry; > - In receiver_call_back (PresentationDispatcher::OnReceiverConnectionAvailable() function), we create a receiver_connection_proxy object, bind it to receiver_connection_request (input parameter) and connect it with controller_connection_proxy (input parameter). Message sending between controller Blink connection and receiver Blink connection may happen afterwards. > > For 2-UA: > - In PresentationServiceDelegateImpl::ConnectToPresentation(), we create a browser_connection_proxy object, bind it to receiver_connection_request (input parameter) and connect it with controller_connection_proxy (input parameter). Message sending from controller Blink connection to media router may happen afterwards. > > More details in code comments and design doc (use chromium.org account): https://docs.google.com/document/d/1XM3jhMJTQyhEC5PDAAJFNIaKh6UUEihqZDz_ztEe4Co/edit#heading=h.hadpx5oi0gml > > Patch set 4 updates: > - added BrowserPresentationConnectionProxy class > - Added PresentationFrame::IsOffscreen() and PresentationFrame::OnBrowserConnectionAvailable() > - PresentationConnection::OnMessage() takes a callback > - PresentationDispatcher::SendXXX() takes PresentationConnectionProxy as parameter > > BUG=525660, 513859 > > Review-Url: https://codereview.chromium.org/2471573005 > Cr-Commit-Position: refs/heads/master@{#448299} > Committed: https://chromium.googlesource.com/chromium/src/+/4b94a1fe3f58aacad2c46bbfd84aa780469e15be TBR=mfoltz@chromium.org,imcheng@chromium.org,jam@chromium.org,miu@chromium.org,zhaobin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=525660, 513859 Review-Url: https://codereview.chromium.org/2674273003 Cr-Commit-Position: refs/heads/master@{#448341} Committed: https://chromium.googlesource.com/chromium/src/+/85671a55bef6e30d53982b94647b5ba85a7eee77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -636 lines) Patch
M chrome/browser/extensions/api/tab_capture/offscreen_tab.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/media/router/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/media/router/browser_presentation_connection_proxy.h View 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/browser/media/router/browser_presentation_connection_proxy.cc View 1 chunk +0 lines, -94 lines 0 comments Download
D chrome/browser/media/router/browser_presentation_connection_proxy_unittest.cc View 1 chunk +0 lines, -116 lines 0 comments Download
M chrome/browser/media/router/presentation_service_delegate_impl.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/media/router/presentation_service_delegate_impl.cc View 12 chunks +27 lines, -113 lines 0 comments Download
M chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc View 4 chunks +4 lines, -24 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/presentation/presentation_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/presentation/presentation_service_impl_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/public/browser/presentation_service_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/presentation/presentation_dispatcher.h View 3 chunks +0 lines, -14 lines 0 comments Download
M content/renderer/presentation/presentation_dispatcher.cc View 5 chunks +14 lines, -38 lines 0 comments Download
M content/renderer/presentation/presentation_dispatcher_unittest.cc View 9 chunks +66 lines, -137 lines 0 comments Download
M content/renderer/presentation/test_presentation_connection.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/presentation/test_presentation_connection.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
joedow
Created Revert of [Presentation API] (5th) (1-UA) integrate controller and receiver side for 1-UA messaging
3 years, 10 months ago (2017-02-06 19:13:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674273003/1
3 years, 10 months ago (2017-02-06 19:14:10 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 19:17:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/85671a55bef6e30d53982b94647b...

Powered by Google App Engine
This is Rietveld 408576698