Check that the shader source exists before loading from the ProgramCache.

Check that the shader source exists before loading from the ProgramCache.

Now that the program cache is almost always created, the cache should only be
checked when the previously compile shader source exists.  This was hit by
the GPU fuzzer when testing without the program binary extensions enabled.

BUG=688795
BUG=671217
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2674263003
Cr-Commit-Position: refs/heads/master@{#448404}
Committed: https://chromium.googlesource.com/chromium/src/+/cc462262940e863770555a7dba23072480d016df

[Geoff Lang, 2017-02-06 15:45:23]

Description was changed from

==========
Check that the shader source exists before loading from the ProgramCache.

Now that the program cache is almost always created, the cache should only be
checked when the previously compile shader source exists.  This was hit by
the GPU fuzzer when testing without the program binary extensions enabled.

BUG=688795
BUG=671217
==========

to

==========
Check that the shader source exists before loading from the ProgramCache.

Now that the program cache is almost always created, the cache should only be
checked when the previously compile shader source exists.  This was hit by
the GPU fuzzer when testing without the program binary extensions enabled.

BUG=688795
BUG=671217
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Geoff Lang, 2017-02-06 15:45:41]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 15:45:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 16:51:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 16:51:54]

Dry run: This issue passed the CQ dry run.

[Geoff Lang, 2017-02-06 17:31:56]

Description was changed from

==========
Check that the shader source exists before loading from the ProgramCache.

Now that the program cache is almost always created, the cache should only be
checked when the previously compile shader source exists.  This was hit by
the GPU fuzzer when testing without the program binary extensions enabled.

BUG=688795
BUG=671217
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Check that the shader source exists before loading from the ProgramCache.

Now that the program cache is almost always created, the cache should only be
checked when the previously compile shader source exists.  This was hit by
the GPU fuzzer when testing without the program binary extensions enabled.

BUG=688795
BUG=671217
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Geoff Lang, 2017-02-06 17:31:56]

geofflang@chromium.org changed reviewers:
+ jbauman@chromium.org

[Geoff Lang, 2017-02-06 17:32:04]

PTAL

[jbauman, 2017-02-06 21:26:45]

lgtm

[Geoff Lang, 2017-02-06 21:45:34]

The CQ bit was checked by geofflang@chromium.org

[commit-bot: I haz the power, 2017-02-06 21:46:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 21:52:51]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486417534846800, "parent_rev":
"85697ebe9a2873ec8935ce8a8b145a918cef52ed", "commit_rev":
"cc462262940e863770555a7dba23072480d016df"}

[commit-bot: I haz the power, 2017-02-06 21:53:33]

Description was changed from

==========
Check that the shader source exists before loading from the ProgramCache.

Now that the program cache is almost always created, the cache should only be
checked when the previously compile shader source exists.  This was hit by
the GPU fuzzer when testing without the program binary extensions enabled.

BUG=688795
BUG=671217
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Check that the shader source exists before loading from the ProgramCache.

Now that the program cache is almost always created, the cache should only be
checked when the previously compile shader source exists.  This was hit by
the GPU fuzzer when testing without the program binary extensions enabled.

BUG=688795
BUG=671217
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2674263003
Cr-Commit-Position: refs/heads/master@{#448404}
Committed:
https://chromium.googlesource.com/chromium/src/+/cc462262940e863770555a7dba23...
==========

[commit-bot: I haz the power, 2017-02-06 21:53:34]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cc462262940e863770555a7dba23...