Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 2674253005: MD WebUI: add node{,_modules}.py as inputs to vulcanize() GN rules (Closed)

Created:
3 years, 10 months ago by Dan Beam
Modified:
3 years, 10 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD WebUI: add node{,_modules}.py as inputs to vulcanize() GN rules R=dpapad@chromium.org BUG=673825 Review-Url: https://codereview.chromium.org/2674253005 Cr-Commit-Position: refs/heads/master@{#448386} Committed: https://chromium.googlesource.com/chromium/src/+/56e678fa1a7a3543d5f6f026ea1823af17a54433

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/resources/vulcanize.gni View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Dan Beam
3 years, 10 months ago (2017-02-06 19:35:22 UTC) #2
dpapad
lgtm
3 years, 10 months ago (2017-02-06 19:42:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674253005/1
3 years, 10 months ago (2017-02-06 19:53:27 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 21:09:40 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/56e678fa1a7a3543d5f6f026ea18...

Powered by Google App Engine
This is Rietveld 408576698