Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2674203002: Ignore generic IC state count for Ignition->Turbo tier up decision. (Closed)

Created:
3 years, 10 months ago by Jarin
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ignore generic IC state count for Ignition->Turbo tier up decision. We benefit from the optimizing compiler even if the IC state is generic, so we'd better ignore the generic IC state count for the optimization decision. This improves our speedometer score from 61.5 to 63.7 (default configuration is 65.9). Review-Url: https://codereview.chromium.org/2674203002 Cr-Commit-Position: refs/heads/master@{#42955} Committed: https://chromium.googlesource.com/v8/v8/+/252eb7054dfd02722f8c468532c8252073c87f51

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M src/runtime-profiler.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Jarin
Could you take a look, please?
3 years, 10 months ago (2017-02-06 09:56:36 UTC) #2
mythria
lgtm.
3 years, 10 months ago (2017-02-06 10:02:10 UTC) #5
Benedikt Meurer
LGTM.
3 years, 10 months ago (2017-02-06 10:03:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674203002/1
3 years, 10 months ago (2017-02-06 10:16:35 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 10:22:13 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/252eb7054dfd02722f8c468532c8252073c...

Powered by Google App Engine
This is Rietveld 408576698