Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2674133002: [cleanup] fix comment in builtins-typedarray.cc (Closed)

Created:
3 years, 10 months ago by caitp
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] fix comment in builtins-typedarray.cc It's supposed to be a JSTypedArray, not a JSGeneratorObject BUG= R=littledan@chromium.org, adamk@chromium.org, jgruber@chromium.org Review-Url: https://codereview.chromium.org/2674133002 Cr-Commit-Position: refs/heads/master@{#42967} Committed: https://chromium.googlesource.com/v8/v8/+/ec922ef6c73f4917cc9f39e28204fbe36ce0ddb1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/builtins/builtins-typedarray.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
caitp
here's a really quick one, PTAL
3 years, 10 months ago (2017-02-06 01:51:03 UTC) #1
jgruber
lgtm
3 years, 10 months ago (2017-02-06 08:02:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674133002/1
3 years, 10 months ago (2017-02-06 12:39:57 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 13:05:52 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/ec922ef6c73f4917cc9f39e28204fbe36ce...

Powered by Google App Engine
This is Rietveld 408576698