Scalable spelling/grammar markers

Scalable spelling/grammar markers

Replace the inlined bitmap markers with vector drawings, to improve rendering
at arbitrary zoom levels.  Use cached SKP recordings for marker fragments, and
a picture shader for tiling in X.

In order to minimize disruption, this change aims to keep rendering as close
to the original bitmaps as possible.  This can be revisited in the future
(to e.g. improve dot spacing/distribution on Mac).

Performance should be comparable to the current bitmap shader impl: Skia
caches picture shader tiles, so for a given zoom level all markers should be
hitting the same pre-rasterized cache entry (and essentially devolve into
bitmap shaders).

R=schenney@chromium.org
BUG=686792
Review-Url: https://codereview.chromium.org/2674003002
Cr-Commit-Position: refs/heads/master@{#449024}
Committed: https://chromium.googlesource.com/chromium/src/+/b09cbee7a1edeb61ea0a594ac800090f62cb4248

[f(malita), 2017-02-06 21:16:29]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 21:16:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 22:46:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 22:46:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[f(malita), 2017-02-07 15:44:12]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 15:44:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-02-07 16:01:54]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 16:02:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-02-07 16:08:18]

Description was changed from

==========
Scalable document makers

WIP

BUG=
==========

to

==========
Scalable spelling/grammar markers

Replace the inlined bitmap markers with vector drawings, to improve rendering
at arbitrary zoom levels.



BUG=
==========

[f(malita), 2017-02-07 16:14:46]

Description was changed from

==========
Scalable spelling/grammar markers

Replace the inlined bitmap markers with vector drawings, to improve rendering
at arbitrary zoom levels.



BUG=
==========

to

==========
Scalable spelling/grammar markers

Replace the inlined bitmap markers with vector drawings, to improve rendering
at arbitrary zoom levels.  Use cached SKP recordings for marker fragments, and
SkPictureShader for tiling in X.

In order to minimize disruption, this change aims to keep rendering as close
to the original bitmaps as possible.  This can be revisited in the future
(to e.g. improve dot spacing/distribution on Mac).

Performance should be comparable with the current bitmap shader impl: Skia
caches picture shader tiles, so for a given zoom level all markers should be
hitting the same pre-rasterized cache entry (and essentially devolve into
bitmap shaders).

R=schenney@chromium.org
==========

[f(malita), 2017-02-07 16:14:46]

fmalita@chromium.org changed reviewers:
+ chrishtr@chromium.org, reed@google.com, schenney@chromium.org

[f(malita), 2017-02-07 16:15:20]

Description was changed from

==========
Scalable spelling/grammar markers

Replace the inlined bitmap markers with vector drawings, to improve rendering
at arbitrary zoom levels.  Use cached SKP recordings for marker fragments, and
SkPictureShader for tiling in X.

In order to minimize disruption, this change aims to keep rendering as close
to the original bitmaps as possible.  This can be revisited in the future
(to e.g. improve dot spacing/distribution on Mac).

Performance should be comparable with the current bitmap shader impl: Skia
caches picture shader tiles, so for a given zoom level all markers should be
hitting the same pre-rasterized cache entry (and essentially devolve into
bitmap shaders).

R=schenney@chromium.org
==========

to

==========
Scalable spelling/grammar markers

Replace the inlined bitmap markers with vector drawings, to improve rendering
at arbitrary zoom levels.  Use cached SKP recordings for marker fragments, and
a picture shader for tiling in X.

In order to minimize disruption, this change aims to keep rendering as close
to the original bitmaps as possible.  This can be revisited in the future
(to e.g. improve dot spacing/distribution on Mac).

Performance should be comparable with the current bitmap shader impl: Skia
caches picture shader tiles, so for a given zoom level all markers should be
hitting the same pre-rasterized cache entry (and essentially devolve into
bitmap shaders).

R=schenney@chromium.org
==========

[f(malita), 2017-02-07 16:27:27]

fmalita@chromium.org changed reviewers:
- chrishtr@chromium.org

[commit-bot: I haz the power, 2017-02-07 17:43:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 17:43:32]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[f(malita), 2017-02-07 18:15:25]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 18:15:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 19:20:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 19:20:36]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[f(malita), 2017-02-07 19:40:34]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 19:41:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-02-07 20:43:32]

Diffs show the expected hi-res improvements -

Mac:
https://storage.googleapis.com/chromium-layout-test-archives/mac_chromium_rel...

Win/Linux:
https://storage.googleapis.com/chromium-layout-test-archives/win10_blink_rel/...

[Stephen Chennney, 2017-02-07 21:12:02]

LGTM. Thanks for following up.

[commit-bot: I haz the power, 2017-02-07 21:19:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 21:19:56]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[f(malita), 2017-02-08 13:38:30]

Description was changed from

==========
Scalable spelling/grammar markers

Replace the inlined bitmap markers with vector drawings, to improve rendering
at arbitrary zoom levels.  Use cached SKP recordings for marker fragments, and
a picture shader for tiling in X.

In order to minimize disruption, this change aims to keep rendering as close
to the original bitmaps as possible.  This can be revisited in the future
(to e.g. improve dot spacing/distribution on Mac).

Performance should be comparable with the current bitmap shader impl: Skia
caches picture shader tiles, so for a given zoom level all markers should be
hitting the same pre-rasterized cache entry (and essentially devolve into
bitmap shaders).

R=schenney@chromium.org
==========

to

==========
Scalable spelling/grammar markers

Replace the inlined bitmap markers with vector drawings, to improve rendering
at arbitrary zoom levels.  Use cached SKP recordings for marker fragments, and
a picture shader for tiling in X.

In order to minimize disruption, this change aims to keep rendering as close
to the original bitmaps as possible.  This can be revisited in the future
(to e.g. improve dot spacing/distribution on Mac).

Performance should be comparable to the current bitmap shader impl: Skia
caches picture shader tiles, so for a given zoom level all markers should be
hitting the same pre-rasterized cache entry (and essentially devolve into
bitmap shaders).

R=schenney@chromium.org
==========

[f(malita), 2017-02-08 14:55:27]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2017-02-08 14:55:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
schenney@chromium.org
Link to the patchset: https://codereview.chromium.org/2674003002/#ps200001
(title: "rebaseline")

[commit-bot: I haz the power, 2017-02-08 14:55:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-02-08 15:08:55]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2017-02-08 15:08:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
schenney@chromium.org
Link to the patchset: https://codereview.chromium.org/2674003002/#ps220001
(title: "formatting")

[commit-bot: I haz the power, 2017-02-08 15:09:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-02-08 16:31:33]

Description was changed from

==========
Scalable spelling/grammar markers

Replace the inlined bitmap markers with vector drawings, to improve rendering
at arbitrary zoom levels.  Use cached SKP recordings for marker fragments, and
a picture shader for tiling in X.

In order to minimize disruption, this change aims to keep rendering as close
to the original bitmaps as possible.  This can be revisited in the future
(to e.g. improve dot spacing/distribution on Mac).

Performance should be comparable to the current bitmap shader impl: Skia
caches picture shader tiles, so for a given zoom level all markers should be
hitting the same pre-rasterized cache entry (and essentially devolve into
bitmap shaders).

R=schenney@chromium.org
==========

to

==========
Scalable spelling/grammar markers

Replace the inlined bitmap markers with vector drawings, to improve rendering
at arbitrary zoom levels.  Use cached SKP recordings for marker fragments, and
a picture shader for tiling in X.

In order to minimize disruption, this change aims to keep rendering as close
to the original bitmaps as possible.  This can be revisited in the future
(to e.g. improve dot spacing/distribution on Mac).

Performance should be comparable to the current bitmap shader impl: Skia
caches picture shader tiles, so for a given zoom level all markers should be
hitting the same pre-rasterized cache entry (and essentially devolve into
bitmap shaders).

R=schenney@chromium.org
BUG=686792
==========

[commit-bot: I haz the power, 2017-02-08 17:30:14]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1486566535390100,
"parent_rev": "9ea4b653af65fdb18c37f54d9986708f5277f8db", "commit_rev":
"b09cbee7a1edeb61ea0a594ac800090f62cb4248"}

[commit-bot: I haz the power, 2017-02-08 17:30:54]

Description was changed from

==========
Scalable spelling/grammar markers

Replace the inlined bitmap markers with vector drawings, to improve rendering
at arbitrary zoom levels.  Use cached SKP recordings for marker fragments, and
a picture shader for tiling in X.

In order to minimize disruption, this change aims to keep rendering as close
to the original bitmaps as possible.  This can be revisited in the future
(to e.g. improve dot spacing/distribution on Mac).

Performance should be comparable to the current bitmap shader impl: Skia
caches picture shader tiles, so for a given zoom level all markers should be
hitting the same pre-rasterized cache entry (and essentially devolve into
bitmap shaders).

R=schenney@chromium.org
BUG=686792
==========

to

==========
Scalable spelling/grammar markers

Replace the inlined bitmap markers with vector drawings, to improve rendering
at arbitrary zoom levels.  Use cached SKP recordings for marker fragments, and
a picture shader for tiling in X.

In order to minimize disruption, this change aims to keep rendering as close
to the original bitmaps as possible.  This can be revisited in the future
(to e.g. improve dot spacing/distribution on Mac).

Performance should be comparable to the current bitmap shader impl: Skia
caches picture shader tiles, so for a given zoom level all markers should be
hitting the same pre-rasterized cache entry (and essentially devolve into
bitmap shaders).

R=schenney@chromium.org
BUG=686792

Review-Url: https://codereview.chromium.org/2674003002
Cr-Commit-Position: refs/heads/master@{#449024}
Committed:
https://chromium.googlesource.com/chromium/src/+/b09cbee7a1edeb61ea0a594ac800...
==========

[commit-bot: I haz the power, 2017-02-08 17:30:57]

Committed patchset #12 (id:220001) as
https://chromium.googlesource.com/chromium/src/+/b09cbee7a1edeb61ea0a594ac800...

[Stephen White, 2017-03-02 15:04:00]

Just saw this in the Skia update. This is really awesome work, Florin!

[Stephen White, 2017-03-02 15:06:25]

senorblanco@chromium.org changed reviewers:
+ senorblanco@chromium.org

[Stephen White, 2017-03-02 15:06:26]

https://codereview.chromium.org/2674003002/diff/220001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp (right):

https://codereview.chromium.org/2674003002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp:47: #include
"third_party/skia/include/core/SkUnPreMultiply.h"
uNit: is this still used anywhere? Maybe it could be removed in a followup if
not.

[f(malita), 2017-03-03 19:16:09]

https://codereview.chromium.org/2674003002/diff/220001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp (right):

https://codereview.chromium.org/2674003002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp:47: #include
"third_party/skia/include/core/SkUnPreMultiply.h"
On 2017/03/02 15:06:26, Stephen White wrote:
> uNit: is this still used anywhere? Maybe it could be removed in a followup if
> not.

Hmm, nope, how did it sneak in there? :)

Thanks, I'll remove.