Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2673953003: Allow origin trials to be enabled by script (Closed)

Created:
3 years, 10 months ago by chasej
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Allow origin trials to be enabled by script Design doc: https://docs.google.com/a/chromium.org/document/d/1oGM6VErHxxvA4JsjstNa6NizC4S5d6f-VrcjHMVYJyE/edit?usp=sharing BUG=667301 Review-Url: https://codereview.chromium.org/2640823004 Cr-Commit-Position: refs/heads/master@{#447471} (cherry picked from commit 8206eacd2be4650deb6d9c706533ee6473d6dd3d) Review-Url: https://codereview.chromium.org/2673953003 . Cr-Commit-Position: refs/branch-heads/2987@{#306} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/1c1b93c301c2a337af0286eb4146bf5d35ace851

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1891 lines, -86 lines) Patch
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/disabled-worker.js View 1 chunk +13 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origin_trials.js View 2 chunks +5 lines, -6 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-script-added.html View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-script-added-before-access.html View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/foreignfetch-origin-trial-interfaces.html View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/foreignfetch-origin-trial-interfaces-expected.txt View 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/imagecapture-origin-trial-interfaces.html View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/imagecapture-origin-trial-interfaces-expected.txt View 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/imagecapture-origin-trial-interfaces-script-added.html View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/imagecapture-origin-trial-interfaces-script-added-expected.txt View 1 chunk +67 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/longtask-origin-trial-interfaces.html View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/longtask-origin-trial-interfaces-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/longtask-origin-trial-interfaces-script-added.html View 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/longtask-origin-trial-interfaces-script-added-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/resources/foreignfetch-origin-trial-interfaces-worker.php View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/rootscroller-origin-trial-interfaces.html View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/rootscroller-origin-trial-interfaces-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/rootscroller-origin-trial-interfaces-script-added.html View 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/rootscroller-origin-trial-interfaces-script-added-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/webusb-origin-trial-interfaces.html View 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/webusb-origin-trial-interfaces-expected.txt View 1 chunk +91 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/webusb-origin-trial-interfaces-script-added.html View 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/webusb-origin-trial-interfaces-script-added-expected.txt View 1 chunk +179 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/resources/origin-trials-helper.js View 1 chunk +134 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/origin-trials-features-disabled/http/tests/origin_trials/webexposed/README.txt View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/origin-trials-features-disabled/http/tests/origin_trials/webexposed/foreignfetch-origin-trial-interfaces-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/origin-trials-features-disabled/http/tests/origin_trials/webexposed/imagecapture-origin-trial-interfaces-expected.txt View 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/origin-trials-features-disabled/http/tests/origin_trials/webexposed/imagecapture-origin-trial-interfaces-script-added-expected.txt View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/origin-trials-features-disabled/http/tests/origin_trials/webexposed/longtask-origin-trial-interfaces-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/origin-trials-features-disabled/http/tests/origin_trials/webexposed/longtask-origin-trial-interfaces-script-added-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/origin-trials-features-disabled/http/tests/origin_trials/webexposed/rootscroller-origin-trial-interfaces-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/origin-trials-features-disabled/http/tests/origin_trials/webexposed/rootscroller-origin-trial-interfaces-script-added-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/origin-trials-features-disabled/http/tests/origin_trials/webexposed/webusb-origin-trial-interfaces-expected.txt View 1 chunk +91 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/origin-trials-features-disabled/http/tests/origin_trials/webexposed/webusb-origin-trial-interfaces-script-added-expected.txt View 1 chunk +94 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/stable/http/tests/origin_trials/webexposed/README.txt View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/stable/http/tests/origin_trials/webexposed/foreignfetch-origin-trial-interfaces-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/stable/http/tests/origin_trials/webexposed/imagecapture-origin-trial-interfaces-expected.txt View 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/stable/http/tests/origin_trials/webexposed/imagecapture-origin-trial-interfaces-script-added-expected.txt View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/stable/http/tests/origin_trials/webexposed/longtask-origin-trial-interfaces-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/stable/http/tests/origin_trials/webexposed/longtask-origin-trial-interfaces-script-added-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/stable/http/tests/origin_trials/webexposed/rootscroller-origin-trial-interfaces-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/stable/http/tests/origin_trials/webexposed/rootscroller-origin-trial-interfaces-script-added-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/stable/http/tests/origin_trials/webexposed/webusb-origin-trial-interfaces-expected.txt View 1 chunk +91 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/stable/http/tests/origin_trials/webexposed/webusb-origin-trial-interfaces-script-added-expected.txt View 1 chunk +94 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.h View 2 chunks +30 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp View 5 chunks +67 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp View 2 chunks +110 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/origin_trials/OriginTrialContext.h View 1 chunk +13 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp View 4 chunks +34 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.h View 1 chunk +2 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp View 4 chunks +37 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
chasej
3 years, 10 months ago (2017-02-04 01:57:45 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
1c1b93c301c2a337af0286eb4146bf5d35ace851.

Powered by Google App Engine
This is Rietveld 408576698