Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2673953002: Revert of Update V8 to version 5.8.111. (Closed)

Created:
3 years, 10 months ago by joedow
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update V8 to version 5.8.111. (patchset #1 id:1 of https://codereview.chromium.org/2670973002/ ) Reason for revert: CL Suspected of causing webkit failures in Chromium trybots: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/2007 Test (fails due to leak): inspector/sources/debugger-step/debugger-step-into-custom-element-callbacks.html Original issue's description: > Update V8 to version 5.8.111. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/5dd3abff..6ea247d1 > > Please follow these instructions for assigning/CC'ing issues: > https://github.com/v8/v8/wiki/Triaging%20issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org > > Review-Url: https://codereview.chromium.org/2670973002 > Cr-Commit-Position: refs/heads/master@{#447980} > Committed: https://chromium.googlesource.com/chromium/src/+/49e97227eb3b54d9721c27a37a162dc84355d13f TBR=hablich@chromium.org,littledan@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,v8-autoroll@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
joedow
Created Revert of Update V8 to version 5.8.111.
3 years, 10 months ago (2017-02-03 20:11:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2673953002/1
3 years, 10 months ago (2017-02-03 20:12:17 UTC) #3
commit-bot: I haz the power
Failed to apply patch for DEPS: While running git apply --index -p1; error: patch failed: ...
3 years, 10 months ago (2017-02-03 20:33:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2673953002/1
3 years, 10 months ago (2017-02-03 20:41:27 UTC) #7
commit-bot: I haz the power
Failed to apply patch for DEPS: While running git apply --index -p1; error: patch failed: ...
3 years, 10 months ago (2017-02-03 20:42:24 UTC) #9
Michael Hablich
3 years, 10 months ago (2017-02-03 21:55:29 UTC) #14
Lots of new V8 versions landed in the meantime. I created a manual roll-back:
https://codereview.chromium.org/2672633006

Powered by Google App Engine
This is Rietveld 408576698