Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions. The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732
Review-Url: https://codereview.chromium.org/2673883002
Cr-Commit-Position: refs/heads/master@{#448775}
Committed: https://chromium.googlesource.com/chromium/src/+/92852bfd720a7de34ea103680c5129d7a8745eb8

[zakerinasab, 2017-02-03 16:59:23]

Description was changed from

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions. The
expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732
==========

to

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions. The
expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732
==========

[zakerinasab, 2017-02-03 16:59:23]

zakerinasab@chromium.org changed reviewers:
+ junov@chromium.org

[zakerinasab, 2017-02-03 16:59:38]

CL uploaded. PTAL.

[Justin Novosad, 2017-02-07 16:41:21]

On 2017/02/03 16:59:38, zakerinasab wrote:
> CL uploaded. PTAL.

lgtm with some high-level comments that would be nice to fix but you are free to
ignore:

1. The function checkBlendModeResult is repeated in many tests and could just be
moved to canvas-blending-helpers.js
2. The nested function runTest is not necessary in any of these tests.
3. Many of these test loop on 'blendModes'. Would be more powerful to use
generate_tests() for that.

[zakerinasab, 2017-02-07 20:09:17]

On 2017/02/07 16:41:21, Justin Novosad wrote:
> On 2017/02/03 16:59:38, zakerinasab wrote:
> > CL uploaded. PTAL.
> 
> lgtm with some high-level comments that would be nice to fix but you are free
to
> ignore:
> 
> 1. The function checkBlendModeResult is repeated in many tests and could just
be
> moved to canvas-blending-helpers.js
> 2. The nested function runTest is not necessary in any of these tests.
> 3. Many of these test loop on 'blendModes'. Would be more powerful to use
> generate_tests() for that.

Comments addressed.

[zakerinasab, 2017-02-07 20:09:28]

The CQ bit was checked by zakerinasab@chromium.org

[zakerinasab, 2017-02-07 20:09:29]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2673883002/#ps40001
(title: "Addressing comments")

[commit-bot: I haz the power, 2017-02-07 20:10:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 23:15:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486498168912050,
"parent_rev": "25b1de1a5da3dbe754e4461cdd5c7ca2b3502ab6", "commit_rev":
"92852bfd720a7de34ea103680c5129d7a8745eb8"}

[commit-bot: I haz the power, 2017-02-07 23:16:28]

Description was changed from

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions. The
expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732
==========

to

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions. The
expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732

Review-Url: https://codereview.chromium.org/2673883002
Cr-Commit-Position: refs/heads/master@{#448775}
Committed:
https://chromium.googlesource.com/chromium/src/+/92852bfd720a7de34ea103680c51...
==========

[commit-bot: I haz the power, 2017-02-07 23:16:29]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/92852bfd720a7de34ea103680c51...