Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2673773002: Adds a FlatDomTreeExtractor to headless (Closed)

Created:
3 years, 10 months ago by alex clarke (OOO till 29th)
Modified:
3 years, 10 months ago
Reviewers:
Sami
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds a FlatDomTreeExtractor to headless This is very similar to DomTreeExtractor (which we should remove later) except it uses DOM.getFlattenedDocument. This is useful for very large documents which might otherwise blow up the JSON parse which currently has a nesting depth limit of 200 BUG=546953 Review-Url: https://codereview.chromium.org/2673773002 Cr-Commit-Position: refs/heads/master@{#447907} Committed: https://chromium.googlesource.com/chromium/src/+/6015730691846661c7d49291638ca159c1199496

Patch Set 1 #

Patch Set 2 : Fix DCHECKS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1049 lines, -9 lines) Patch
M headless/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M headless/public/util/dom_tree_extractor.h View 1 chunk +1 line, -0 lines 0 comments Download
A + headless/public/util/flat_dom_tree_extractor.h View 5 chunks +10 lines, -9 lines 0 comments Download
A headless/public/util/flat_dom_tree_extractor.cc View 1 1 chunk +112 lines, -0 lines 0 comments Download
A headless/public/util/flat_dom_tree_extractor_browsertest.cc View 1 1 chunk +923 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
alex clarke (OOO till 29th)
3 years, 10 months ago (2017-02-02 23:23:01 UTC) #3
Sami
lgtm.
3 years, 10 months ago (2017-02-02 23:34:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2673773002/1
3 years, 10 months ago (2017-02-02 23:41:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2673773002/20001
3 years, 10 months ago (2017-02-03 00:48:39 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 03:40:18 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6015730691846661c7d49291638c...

Powered by Google App Engine
This is Rietveld 408576698