Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2673753004: Fix set_up_quic_server_info_factory in HttpCache creation (Closed)

Created:
3 years, 10 months ago by Zhongyi Shi
Modified:
3 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org, mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix set_up_quic_server_info_factory in HttpCache creation BUG=686632 Review-Url: https://codereview.chromium.org/2673753004 Cr-Commit-Position: refs/heads/master@{#448142} Committed: https://chromium.googlesource.com/chromium/src/+/3ceab9f0a58bef737f4685dc030757cbb330d078

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/profiles/profile_io_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M net/url_request/view_cache_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
Zhongyi Shi
3 years, 10 months ago (2017-02-03 18:50:22 UTC) #4
mmenke
[+rch]: Deferring to rch, who is now a ProfileIOData owner. I assume this doesn't disable ...
3 years, 10 months ago (2017-02-03 18:54:57 UTC) #6
Ryan Hamilton
On 2017/02/03 18:54:57, mmenke (Out Feb 4 to March 5) wrote: > [+rch]: Deferring to ...
3 years, 10 months ago (2017-02-03 19:56:28 UTC) #9
Ryan Hamilton
lgtm https://codereview.chromium.org/2673753004/diff/1/net/url_request/url_request_unittest.cc File net/url_request/url_request_unittest.cc (right): https://codereview.chromium.org/2673753004/diff/1/net/url_request/url_request_unittest.cc#newcode7740 net/url_request/url_request_unittest.cc:7740: HttpCache::DefaultBackend::InMemory(0), false); nit: can you comment this boolean ...
3 years, 10 months ago (2017-02-03 19:56:36 UTC) #10
Zhongyi Shi
https://codereview.chromium.org/2673753004/diff/1/net/url_request/url_request_unittest.cc File net/url_request/url_request_unittest.cc (right): https://codereview.chromium.org/2673753004/diff/1/net/url_request/url_request_unittest.cc#newcode7740 net/url_request/url_request_unittest.cc:7740: HttpCache::DefaultBackend::InMemory(0), false); On 2017/02/03 19:56:36, Ryan Hamilton wrote: > ...
3 years, 10 months ago (2017-02-03 20:03:21 UTC) #11
Zhongyi Shi
Landing the code now, move mmenke to cc line as he's OOO from Feb 4th.
3 years, 10 months ago (2017-02-04 00:59:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2673753004/20001
3 years, 10 months ago (2017-02-04 01:00:20 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-04 02:06:49 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3ceab9f0a58bef737f4685dc0307...

Powered by Google App Engine
This is Rietveld 408576698