Fix set_up_quic_server_info_factory in HttpCache creation

Fix set_up_quic_server_info_factory in HttpCache creation

BUG=686632
Review-Url: https://codereview.chromium.org/2673753004
Cr-Commit-Position: refs/heads/master@{#448142}
Committed: https://chromium.googlesource.com/chromium/src/+/3ceab9f0a58bef737f4685dc030757cbb330d078

[Zhongyi Shi, 2017-02-03 18:37:06]

The CQ bit was checked by zhongyi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 18:37:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhongyi Shi, 2017-02-03 18:50:22]

zhongyi@chromium.org changed reviewers:
+ mmenke@chromium.org

[mmenke, 2017-02-03 18:54:56]

mmenke@chromium.org changed reviewers:
+ rch@chromium.org

[mmenke, 2017-02-03 18:54:57]

[+rch]:  Deferring to rch, who is now a ProfileIOData owner.  I assume this
doesn't  disable QUIC for media requests, since the shared HttpNetworkSession
already has the QUIC stuff enabled from the earlier call.

[commit-bot: I haz the power, 2017-02-03 19:33:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 19:33:41]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2017-02-03 19:56:28]

On 2017/02/03 18:54:57, mmenke (Out Feb 4 to March 5) wrote:
> [+rch]:  Deferring to rch, who is now a ProfileIOData owner.  I assume this
> doesn't  disable QUIC for media requests, since the shared HttpNetworkSession
> already has the QUIC stuff enabled from the earlier call.

Correct. This just explicitly disables using the non-main cache for storing QUIC
server configs. Previously this was happening "by accident" by virtue of the
QuicStreamFactory using the only the first call to set_quic_server_info_factory.

[Ryan Hamilton, 2017-02-03 19:56:36]

lgtm

https://codereview.chromium.org/2673753004/diff/1/net/url_request/url_request...
File net/url_request/url_request_unittest.cc (right):

https://codereview.chromium.org/2673753004/diff/1/net/url_request/url_request...
net/url_request/url_request_unittest.cc:7740:
HttpCache::DefaultBackend::InMemory(0), false);
nit: can you comment this boolean literal?

[Zhongyi Shi, 2017-02-03 20:03:21]

https://codereview.chromium.org/2673753004/diff/1/net/url_request/url_request...
File net/url_request/url_request_unittest.cc (right):

https://codereview.chromium.org/2673753004/diff/1/net/url_request/url_request...
net/url_request/url_request_unittest.cc:7740:
HttpCache::DefaultBackend::InMemory(0), false);
On 2017/02/03 19:56:36, Ryan Hamilton wrote:
> nit: can you comment this boolean literal?

Done.

[Zhongyi Shi, 2017-02-04 00:59:36]

zhongyi@chromium.org changed reviewers:
- mmenke@chromium.org

[Zhongyi Shi, 2017-02-04 00:59:36]

Landing the code now, move mmenke to cc line as he's OOO from Feb 4th.

[Zhongyi Shi, 2017-02-04 01:00:00]

The CQ bit was checked by zhongyi@chromium.org

[Zhongyi Shi, 2017-02-04 01:00:01]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2673753004/#ps20001
(title: "add comment")

[commit-bot: I haz the power, 2017-02-04 01:00:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 02:06:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486170000750550,
"parent_rev": "27f47452ef102d6430ca500fd4a27d8edf6de832", "commit_rev":
"3ceab9f0a58bef737f4685dc030757cbb330d078"}

[commit-bot: I haz the power, 2017-02-04 02:06:48]

Description was changed from

==========
Fix set_up_quic_server_info_factory in HttpCache creation

BUG=686632
==========

to

==========
Fix set_up_quic_server_info_factory in HttpCache creation

BUG=686632

Review-Url: https://codereview.chromium.org/2673753004
Cr-Commit-Position: refs/heads/master@{#448142}
Committed:
https://chromium.googlesource.com/chromium/src/+/3ceab9f0a58bef737f4685dc0307...
==========

[commit-bot: I haz the power, 2017-02-04 02:06:49]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3ceab9f0a58bef737f4685dc0307...