Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2673743002: Convert DynamicsCompressor tests to testharness (Closed)

Created:
3 years, 10 months ago by Raymond Toy
Modified:
3 years, 10 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert DynamicsCompressor tests to testharness Manually converted the tests to use testharness. BUG=688150 TEST=dynamicscompressor-basic.html, dynamicscompressor-clear-internal-state.html, dynamicscompressor-simple.html Review-Url: https://codereview.chromium.org/2673743002 Cr-Commit-Position: refs/heads/master@{#448343} Committed: https://chromium.googlesource.com/chromium/src/+/f4cd0aa86e2674238b291fd990ff483df5e844f1

Patch Set 1 #

Patch Set 2 : Remove commented-out code. #

Total comments: 4

Patch Set 3 : Address review comments. #

Messages

Total messages: 10 (5 generated)
Raymond Toy
PTAL
3 years, 10 months ago (2017-02-03 16:46:04 UTC) #2
hongchan
lgtm with nits https://codereview.chromium.org/2673743002/diff/20001/third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html File third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html (right): https://codereview.chromium.org/2673743002/diff/20001/third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html#newcode23 third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html:23: task.describe("Validate Reduction Value of DynamicsCompressor after ...
3 years, 10 months ago (2017-02-06 17:30:26 UTC) #3
Raymond Toy
https://codereview.chromium.org/2673743002/diff/20001/third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html File third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html (right): https://codereview.chromium.org/2673743002/diff/20001/third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html#newcode23 third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html:23: task.describe("Validate Reduction Value of DynamicsCompressor after Disabling"); On 2017/02/06 ...
3 years, 10 months ago (2017-02-06 18:12:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2673743002/40001
3 years, 10 months ago (2017-02-06 18:13:12 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 19:20:08 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f4cd0aa86e2674238b291fd990ff...

Powered by Google App Engine
This is Rietveld 408576698