3 years, 10 months ago
(2017-02-03 16:46:04 UTC)
#2
PTAL
hongchan
lgtm with nits https://codereview.chromium.org/2673743002/diff/20001/third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html File third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html (right): https://codereview.chromium.org/2673743002/diff/20001/third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html#newcode23 third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html:23: task.describe("Validate Reduction Value of DynamicsCompressor after ...
3 years, 10 months ago
(2017-02-06 17:30:26 UTC)
#3
https://codereview.chromium.org/2673743002/diff/20001/third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html File third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html (right): https://codereview.chromium.org/2673743002/diff/20001/third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html#newcode23 third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html:23: task.describe("Validate Reduction Value of DynamicsCompressor after Disabling"); On 2017/02/06 ...
3 years, 10 months ago
(2017-02-06 18:12:20 UTC)
#4
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486404766093630, "parent_rev": "7719f15c6e4eeaaf2ba20f74507ff6d0e6702a6c", "commit_rev": "f4cd0aa86e2674238b291fd990ff483df5e844f1"}
3 years, 10 months ago
(2017-02-06 19:19:37 UTC)
#8
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486404766093630,
"parent_rev": "7719f15c6e4eeaaf2ba20f74507ff6d0e6702a6c", "commit_rev":
"f4cd0aa86e2674238b291fd990ff483df5e844f1"}
commit-bot: I haz the power
Description was changed from ========== Convert DynamicsCompressor tests to testharness Manually converted the tests to ...
3 years, 10 months ago
(2017-02-06 19:20:07 UTC)
#9
Message was sent while issue was closed.
Description was changed from
==========
Convert DynamicsCompressor tests to testharness
Manually converted the tests to use testharness.
BUG=688150
TEST=dynamicscompressor-basic.html,
dynamicscompressor-clear-internal-state.html,
dynamicscompressor-simple.html
==========
to
==========
Convert DynamicsCompressor tests to testharness
Manually converted the tests to use testharness.
BUG=688150
TEST=dynamicscompressor-basic.html,
dynamicscompressor-clear-internal-state.html,
dynamicscompressor-simple.html
Review-Url: https://codereview.chromium.org/2673743002
Cr-Commit-Position: refs/heads/master@{#448343}
Committed:
https://chromium.googlesource.com/chromium/src/+/f4cd0aa86e2674238b291fd990ff...
==========
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/f4cd0aa86e2674238b291fd990ff483df5e844f1
3 years, 10 months ago
(2017-02-06 19:20:08 UTC)
#10
Issue 2673743002: Convert DynamicsCompressor tests to testharness
(Closed)
Created 3 years, 10 months ago by Raymond Toy
Modified 3 years, 10 months ago
Reviewers: hongchan
Base URL:
Comments: 4