DevTools: Speed up timeline aggregated tree building.

DevTools: Speed up timeline aggregated tree building.

The patch makes the bottom-up tree to be built lazily as the user explores its branches.

Review-Url: https://codereview.chromium.org/2673733003
Cr-Commit-Position: refs/heads/master@{#448094}
Committed: https://chromium.googlesource.com/chromium/src/+/2d63693b08d1ccf5e40aeaa8edb20bf86ec9ab3e

[alph, 2017-02-03 03:02:26]

alph@chromium.org changed reviewers:
+ caseq@chromium.org

[alph, 2017-02-03 03:02:27]

The call-tree speedup is coming.

[caseq, 2017-02-03 19:55:25]

you will burn in hell for this. lgtm.

https://codereview.chromium.org/2673733003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
(right):

https://codereview.chromium.org/2673733003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js:21:
return `${data['functionName']}@${data['scriptId'] || data['url'] || ''}`;
let's revert this

https://codereview.chromium.org/2673733003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js
(right):

https://codereview.chromium.org/2673733003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js:326:
this._hasChildren = true;
let's pass the correct value

https://codereview.chromium.org/2673733003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js:364:
console.assert(duration >= 0);
if (duration < 0) console.assert(false, ...);

[alph, 2017-02-03 20:06:02]

https://codereview.chromium.org/2673733003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
(right):

https://codereview.chromium.org/2673733003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js:21:
return `${data['functionName']}@${data['scriptId'] || data['url'] || ''}`;
On 2017/02/03 19:55:25, caseq wrote:
> let's revert this

Done.

https://codereview.chromium.org/2673733003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js
(right):

https://codereview.chromium.org/2673733003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js:326:
this._hasChildren = true;
On 2017/02/03 19:55:25, caseq wrote:
> let's pass the correct value

Done.

https://codereview.chromium.org/2673733003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js:364:
console.assert(duration >= 0);
On 2017/02/03 19:55:25, caseq wrote:
> if (duration < 0) console.assert(false, ...);

Done.

[alph, 2017-02-03 20:06:42]

The CQ bit was checked by alph@chromium.org

[alph, 2017-02-03 20:06:42]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2673733003/#ps20001
(title: "4 landing")

[commit-bot: I haz the power, 2017-02-03 20:07:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 22:42:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486152402074370,
"parent_rev": "8e3a95db1d0748f9bf21238679cdccd8b8ed0754", "commit_rev":
"2d63693b08d1ccf5e40aeaa8edb20bf86ec9ab3e"}

[commit-bot: I haz the power, 2017-02-03 22:42:53]

Description was changed from

==========
DevTools: Speed up timeline aggregated tree building.

The patch makes the bottom-up tree to be built lazily as the user explores its
branches.
==========

to

==========
DevTools: Speed up timeline aggregated tree building.

The patch makes the bottom-up tree to be built lazily as the user explores its
branches.

Review-Url: https://codereview.chromium.org/2673733003
Cr-Commit-Position: refs/heads/master@{#448094}
Committed:
https://chromium.googlesource.com/chromium/src/+/2d63693b08d1ccf5e40aeaa8edb2...
==========

[commit-bot: I haz the power, 2017-02-03 22:42:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2d63693b08d1ccf5e40aeaa8edb2...