Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 267373005: [New Multicolumn] Use the term "content run" in favor of "forced break". (Closed)

Created:
6 years, 7 months ago by mstensho (USE GERRIT)
Modified:
6 years, 7 months ago
CC:
blink-reviews, mstensho+blink_opera.com, blink-reviews-rendering, chromiumbugtracker_adobe.com, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[New Multicolumn] Use the term "content run" in favor of "forced break". You get one content run even without any forced breaks. Documentation improvements. In particular for flow thread layout and column balancing. Also don't assume that a column set starts at flow thread block offset 0. This is only true for the first set. So far we only have one set, but this will soon change, with the introduction of support for column-span:all. Check with the flow thread portion rectangle to get the correct start offset. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173879

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -29 lines) Patch
M Source/core/rendering/RenderMultiColumnFlowThread.h View 1 chunk +34 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnFlowThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMultiColumnSet.h View 3 chunks +11 lines, -8 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnSet.cpp View 8 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mstensho (USE GERRIT)
6 years, 7 months ago (2014-05-07 14:56:03 UTC) #1
mstensho (USE GERRIT)
6 years, 7 months ago (2014-05-10 16:30:38 UTC) #2
Julien - ping for review
lgtm
6 years, 7 months ago (2014-05-12 10:30:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/267373005/1
6 years, 7 months ago (2014-05-12 10:30:19 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-12 11:44:47 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-12 12:57:48 UTC) #6
Message was sent while issue was closed.
Change committed as 173879

Powered by Google App Engine
This is Rietveld 408576698