Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2673673003: Add TEAM/COMPONENT (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 10 months ago
Reviewers:
jsbell, nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, mlamouri+watch-content_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, abarth-chromium, falken+watch_chromium.org, darin-cc_chromium.org, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, kinuko+watch, shimazu+serviceworker_chromium.org, kinuko+fileapi, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add TEAM/COMPONENT BUG=679905 Review-Url: https://codereview.chromium.org/2673673003 Cr-Commit-Position: refs/heads/master@{#448108} Committed: https://chromium.googlesource.com/chromium/src/+/05bd488e584433dabf586586c5d79ee63228ceca

Patch Set 1 : remove mistake file #

Total comments: 14

Patch Set 2 : update compo #

Total comments: 8

Patch Set 3 : update compo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M chrome/browser/ui/webui/sync_file_system_internals/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/fileapi/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/resources/service_worker/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/service_worker/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/child/fileapi/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/child/service_worker/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/fileapi/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/service_worker/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/service_worker/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M storage/browser/fileapi/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M storage/common/fileapi/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-02-02 22:43:04 UTC) #2
nhiroki
+jsbell@, can you check my comment in ontent/browser/fileapi/OWNERS? https://codereview.chromium.org/2673673003/diff/20001/content/browser/fileapi/OWNERS File content/browser/fileapi/OWNERS (right): https://codereview.chromium.org/2673673003/diff/20001/content/browser/fileapi/OWNERS#newcode7 content/browser/fileapi/OWNERS:7: # ...
3 years, 10 months ago (2017-02-03 13:48:24 UTC) #5
jsbell
I agree with nhiroki@ (I'm hoping we can tease apart fileapi and filesystem implementation when ...
3 years, 10 months ago (2017-02-03 17:57:39 UTC) #6
ymzhang1
https://codereview.chromium.org/2673673003/diff/20001/content/browser/fileapi/OWNERS File content/browser/fileapi/OWNERS (right): https://codereview.chromium.org/2673673003/diff/20001/content/browser/fileapi/OWNERS#newcode7 content/browser/fileapi/OWNERS:7: # COMPONENT: Blink>FileAPI On 2017/02/03 17:57:39, jsbell (at-BlinkOn-slow) wrote: ...
3 years, 10 months ago (2017-02-03 19:05:21 UTC) #7
nhiroki
https://codereview.chromium.org/2673673003/diff/20001/content/browser/fileapi/OWNERS File content/browser/fileapi/OWNERS (right): https://codereview.chromium.org/2673673003/diff/20001/content/browser/fileapi/OWNERS#newcode7 content/browser/fileapi/OWNERS:7: # COMPONENT: Blink>FileAPI On 2017/02/03 17:57:39, jsbell wrote: > ...
3 years, 10 months ago (2017-02-03 21:18:34 UTC) #8
ymzhang1
Sorry. I should have made these changes in the previous patch. Thanks for your patience! ...
3 years, 10 months ago (2017-02-03 21:42:20 UTC) #9
nhiroki
LGTM! On 2017/02/03 21:42:20, ymzhang1 wrote: > Sorry. I should have made these changes in ...
3 years, 10 months ago (2017-02-03 21:47:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2673673003/60001
3 years, 10 months ago (2017-02-03 21:49:42 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 23:37:04 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/05bd488e584433dabf586586c5d7...

Powered by Google App Engine
This is Rietveld 408576698