Fix: absolutely positioned block too wide in LegacyLayout

Fix: absolutely positioned block too wide in LegacyLayout

example:
<style type="text/css">
  div#green-overlapping-test
    {
      border-left: green solid 25px;
      border-right: green solid 75px;
      height: 100px;
      left: auto;
      position: absolute;
      right: auto;
      width: auto;
      writing-mode: horizontal-tb;
    }

     div#red-overlapped-reference
    {
      background-color: red;
      height: 100px;
      width: 100px;
    }

</style>
  <div id="green-overlapping-test"></div>
  <div id="red-overlapped-reference"></div>

cause:
Inside ng_block_layout_algorithm, we set initial inline length to
width of containing space.
inline_length comes from ResolveInlineLength.
As containing_space does not have ShrinkToFit flag, ResolveInlineLength defaults
to width of containing box.
I believe containing_space should have ShrinkToFit flag set.

This flag is set here:
 NGConstraintSpace::CreateFromLayoutObject
   .SetIsShrinkToFit(
          box.sizesLogicalWidthToFitContent(box.styleRef().logicalWidth()))

My guess is that sizesLogicalWidthToFitContent should return true for
out_of_flow blocks, but with old layout, one can never be sure.
I've ran the full LayoutTests suite, and it works with the patch.


BUG=635619
Review-Url: https://codereview.chromium.org/2673583005
Cr-Commit-Position: refs/heads/master@{#448123}
Committed: https://chromium.googlesource.com/chromium/src/+/e37073cf5dc5e7e0a770e967af8571d455cacfe4

[atotic, 2017-02-03 21:51:40]

atotic@chromium.org changed reviewers:
+ cbiesinger@chromium.org

[atotic, 2017-02-03 21:52:06]

ptal

Minor bug I've encountered when attempting to run csswg test suite.

[cbiesinger, 2017-02-03 22:22:05]

ok, lgtm. this should not have an adverse effect of legacy layout because that
goes through a different function for sizing out-of-flow objects.

[atotic, 2017-02-03 22:24:27]

The CQ bit was checked by atotic@chromium.org

[commit-bot: I haz the power, 2017-02-03 22:25:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 00:42:07]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486160667222400, "parent_rev":
"47e3bdfb0e61b4f755228b878933444cc55d7f13", "commit_rev":
"e37073cf5dc5e7e0a770e967af8571d455cacfe4"}

[commit-bot: I haz the power, 2017-02-04 00:42:38]

Description was changed from

==========
Fix: absolutely positioned block too wide in LegacyLayout

example:
<style type="text/css">
  div#green-overlapping-test
    {
      border-left: green solid 25px;
      border-right: green solid 75px;
      height: 100px;
      left: auto;
      position: absolute;
      right: auto;
      width: auto;
      writing-mode: horizontal-tb;
    }

     div#red-overlapped-reference
    {
      background-color: red;
      height: 100px;
      width: 100px;
    }

</style>
  <div id="green-overlapping-test"></div>
  <div id="red-overlapped-reference"></div>

cause:
Inside ng_block_layout_algorithm, we set initial inline length to
width of containing space.
inline_length comes from ResolveInlineLength.
As containing_space does not have ShrinkToFit flag, ResolveInlineLength defaults
to width of containing box.
I believe containing_space should have ShrinkToFit flag set.

This flag is set here:
 NGConstraintSpace::CreateFromLayoutObject
   .SetIsShrinkToFit(
          box.sizesLogicalWidthToFitContent(box.styleRef().logicalWidth()))

My guess is that sizesLogicalWidthToFitContent should return true for
out_of_flow blocks, but with old layout, one can never be sure.
I've ran the full LayoutTests suite, and it works with the patch.


BUG=635619
==========

to

==========
Fix: absolutely positioned block too wide in LegacyLayout

example:
<style type="text/css">
  div#green-overlapping-test
    {
      border-left: green solid 25px;
      border-right: green solid 75px;
      height: 100px;
      left: auto;
      position: absolute;
      right: auto;
      width: auto;
      writing-mode: horizontal-tb;
    }

     div#red-overlapped-reference
    {
      background-color: red;
      height: 100px;
      width: 100px;
    }

</style>
  <div id="green-overlapping-test"></div>
  <div id="red-overlapped-reference"></div>

cause:
Inside ng_block_layout_algorithm, we set initial inline length to
width of containing space.
inline_length comes from ResolveInlineLength.
As containing_space does not have ShrinkToFit flag, ResolveInlineLength defaults
to width of containing box.
I believe containing_space should have ShrinkToFit flag set.

This flag is set here:
 NGConstraintSpace::CreateFromLayoutObject
   .SetIsShrinkToFit(
          box.sizesLogicalWidthToFitContent(box.styleRef().logicalWidth()))

My guess is that sizesLogicalWidthToFitContent should return true for
out_of_flow blocks, but with old layout, one can never be sure.
I've ran the full LayoutTests suite, and it works with the patch.


BUG=635619

Review-Url: https://codereview.chromium.org/2673583005
Cr-Commit-Position: refs/heads/master@{#448123}
Committed:
https://chromium.googlesource.com/chromium/src/+/e37073cf5dc5e7e0a770e967af85...
==========

[commit-bot: I haz the power, 2017-02-04 00:42:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e37073cf5dc5e7e0a770e967af85...