Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2673563002: MD Settings: Remove unnecessary importHtml() calls in site-settings tests. (Closed)

Created:
3 years, 10 months ago by dpapad
Modified:
3 years, 10 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Remove unnecessary importHtml() calls in site-settings tests. Load privacy_page.html as browserPreload in site settings tests to bring in all necessary dependencies. Previously site settings loaded prefs.html which does not bring in any of the dependencies needed for the test to run. Then it programmatically loaded test deps, which is unnecessary. BUG=673825 Review-Url: https://codereview.chromium.org/2673563002 Cr-Commit-Position: refs/heads/master@{#447817} Committed: https://chromium.googlesource.com/chromium/src/+/68c7a441710ebec8b3143eca64f4eb92da482737

Patch Set 1 : More #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -35 lines) Patch
M chrome/test/data/webui/settings/category_default_setting_tests.js View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/test/data/webui/settings/category_setting_exceptions_tests.js View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/test/data/webui/settings/cr_settings_browsertest.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/settings/protocol_handlers_tests.js View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/test/data/webui/settings/site_list_tests.js View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/webui/settings/usb_devices_tests.js View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/test/data/webui/settings/zoom_levels_tests.js View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
dpapad
3 years, 10 months ago (2017-02-02 02:22:26 UTC) #12
Dan Beam
lgtm!
3 years, 10 months ago (2017-02-02 03:57:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2673563002/60001
3 years, 10 months ago (2017-02-02 18:10:22 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 19:32:46 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/68c7a441710ebec8b3143eca64f4...

Powered by Google App Engine
This is Rietveld 408576698