Migrate WTF::HashMap::remove() to ::erase()

Migrate WTF::HashMap::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

This CL migrates most, but not all references to one type of remove()
method (that takes a KeyPeekInType).

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2673543003
Cr-Commit-Position: refs/heads/master@{#447913}
Committed: https://chromium.googlesource.com/chromium/src/+/6e15bee70f49af0442300b3b4d59a7a65ed0555e

[pilgrim_google, 2017-02-02 21:14:38]

pilgrim@chromium.org changed reviewers:
+ esprehn@chromium.org, haraken@chromium.org, yutak@chromium.org

[pilgrim_google, 2017-02-02 21:14:39]

Description was changed from

==========
Migrate WTF::HashMap::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

This CL migrates most, but not all references to one type of remove()
method (that takes a KeyPeekInType).

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
==========

to

==========
Migrate WTF::HashMap::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

This CL migrates most, but not all references to one type of remove()
method (that takes a KeyPeekInType).

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[pilgrim_google, 2017-02-02 21:14:40]

Description was changed from

==========
Migrate WTF::HashMap::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

This CL migrates most, but not all references to one type of remove()
method (that takes a KeyPeekInType).

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Migrate WTF::HashMap::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

This CL migrates most, but not all references to one type of remove()
method (that takes a KeyPeekInType).

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pilgrim_google, 2017-02-02 21:14:46]

The CQ bit was checked by pilgrim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 21:15:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-02-02 22:47:00]

LGTM

[commit-bot: I haz the power, 2017-02-02 23:21:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 23:21:19]

Dry run: This issue passed the CQ dry run.

[pilgrim_google, 2017-02-03 00:36:54]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2017-02-03 00:37:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 03:48:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486082214189200, "parent_rev":
"c2e2536fd4863b73fa2a2f64f3ab251fc6ef8a6b", "commit_rev":
"6e15bee70f49af0442300b3b4d59a7a65ed0555e"}

[commit-bot: I haz the power, 2017-02-03 03:49:15]

Description was changed from

==========
Migrate WTF::HashMap::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

This CL migrates most, but not all references to one type of remove()
method (that takes a KeyPeekInType).

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Migrate WTF::HashMap::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

This CL migrates most, but not all references to one type of remove()
method (that takes a KeyPeekInType).

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2673543003
Cr-Commit-Position: refs/heads/master@{#447913}
Committed:
https://chromium.googlesource.com/chromium/src/+/6e15bee70f49af0442300b3b4d59...
==========

[commit-bot: I haz the power, 2017-02-03 03:49:18]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6e15bee70f49af0442300b3b4d59...