Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: runtime/bin/builtin_nolib.cc

Issue 267353005: - Change when the library being loaded is registered. Now (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/builtin.cc ('k') | runtime/bin/dartutils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/builtin_nolib.cc
===================================================================
--- runtime/bin/builtin_nolib.cc (revision 35776)
+++ runtime/bin/builtin_nolib.cc (working copy)
@@ -53,6 +53,12 @@
}
+Dart_Handle Builtin::LoadLibrary(Dart_Handle url, BuiltinLibraryId id) {
+ return DartUtils::NewError(
+ "Unreachable code in Builtin::LoadLibrary (%d).", id);
hausner 2014/05/07 20:06:19 No space before (%d)
Ivan Posva 2014/05/07 21:45:46 The space is needed if you do "XYZ (%" Pd " ).", b
hausner 2014/05/07 21:56:46 What I mean is: "Unreachable code in Builtin::Loa
+}
+
+
Dart_Handle Builtin::LoadAndCheckLibrary(BuiltinLibraryId id) {
ASSERT((sizeof(builtin_libraries_) / sizeof(builtin_lib_props)) ==
kInvalidLibrary);
« no previous file with comments | « runtime/bin/builtin.cc ('k') | runtime/bin/dartutils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698