- Change when the library being loaded is registered. Now

runtime/bin/builtin_nolib.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <stdio.h>
 
 #include "include/dart_api.h"
 
 #include "bin/builtin.h"
 #include "bin/dartutils.h"
@@ skipping 35 matching lines @@
     Dart_Handle url = DartUtils::NewString(builtin_libraries_[id].url_);
     Dart_Handle library = Dart_LookupLibrary(url);
     ASSERT(!Dart_IsError(library));
     // Setup the native resolver for built in library functions.
     DART_CHECK_VALID(
         Dart_SetNativeResolver(library, NativeLookup, NativeSymbol));
   }
 }
 
 
+Dart_Handle Builtin::LoadLibrary(Dart_Handle url, BuiltinLibraryId id) {
+  return DartUtils::NewError(
+      "Unreachable code in Builtin::LoadLibrary (%d).", id);

[hausner, 2014/05/07 20:06:19]

No space before (%d)

[Ivan Posva, 2014/05/07 21:45:46]

The space is needed if you do "XYZ (%" Pd " ).", but not here where a space
would change the formatting of the output.

[hausner, 2014/05/07 21:56:46]

What I mean is:

"Unreachable code in Builtin::LoadLibrary(%d)."

No space between y and (.

+}
+
+
 Dart_Handle Builtin::LoadAndCheckLibrary(BuiltinLibraryId id) {
   ASSERT((sizeof(builtin_libraries_) / sizeof(builtin_lib_props)) ==
          kInvalidLibrary);
   ASSERT(id >= kBuiltinLibrary && id < kInvalidLibrary);
   Dart_Handle url = DartUtils::NewString(builtin_libraries_[id].url_);
   Dart_Handle library = Dart_LookupLibrary(url);
   DART_CHECK_VALID(library);
   return library;
 }
 
 }  // namespace bin
 }  // namespace dart