Slightly simplify location bar bg/border painting.

Slightly simplify location bar bg/border painting.

I also renamed some stuff to improve clarity (I couldn't initially 
determine why GetBorderColor didn't return the same thing as 
kBorderColor). This shouldn't cause any behavioral change. The unneeded 
complexity here was probably left over from pre-MD codepaths.

BUG=648281
Review-Url: https://codereview.chromium.org/2673503002
Cr-Commit-Position: refs/heads/master@{#447881}
Committed: https://chromium.googlesource.com/chromium/src/+/ff3e5ef957ccb585c7d73a0b011bdd432f5e57e0

[Evan Stade, 2017-02-01 23:43:09]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 23:43:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2017-02-01 23:55:47]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 23:56:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2017-02-01 23:56:41]

Description was changed from

==========
Slightly simplify location bar bg/border painting.

This shouldn't have any impact on normal themed, regular or incognito
browser windows. It will have a slight impact on themed windows because
the border will be blended with the toolbar color instead of being
overlaid on the toolbar image.

The unneeded complexity here was probably left over from pre-MD
codepaths.

BUG=648281
==========

to

==========
Slightly simplify location bar bg/border painting.

I also renamed some stuff to improve clarity (I couldn't initially 
determine why GetBorderColor didn't return the same thing as 
kBorderColor). This shouldn't cause any behavioral change. The unneeded 
complexity here was probably left over from pre-MD codepaths.

BUG=648281
==========

[Evan Stade, 2017-02-01 23:56:41]

estade@chromium.org changed reviewers:
+ pkasting@chromium.org

[Evan Stade, 2017-02-01 23:58:34]

https://codereview.chromium.org/2673503002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/location_bar/location_bar_view.cc (left):

https://codereview.chromium.org/2673503002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/location_bar_view.cc:1158:
bounds.Inset(GetHorizontalEdgeThickness(),
since is_popup_mode_ is true, this was returning 0

https://codereview.chromium.org/2673503002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/location_bar_view.cc:1159: is_popup_mode_
always true

[Evan Stade, 2017-02-02 00:01:09]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 00:01:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Kasting, 2017-02-02 00:51:35]

LGTM

https://codereview.chromium.org/2673503002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/location_bar/location_bar_view.cc (right):

https://codereview.chromium.org/2673503002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/location_bar_view.cc:169: kBorderOpacity);
Even simpler: Leave kBorderColor as partly-transparent, and implement as:

  const SkColor toolbar_color =
      ThemeProperties::GetDefaultColor(ThemeProperties::COLOR_TOOLBAR,
incognito);
  return color_utils::GetResultingPaintColor(kBorderColor, toolbar_color);

This allows reverting to one constant and continuing to pass the
partly-transparent value in OnNativeThemeChanged() as before.

[commit-bot: I haz the power, 2017-02-02 00:58:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 00:58:06]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2017-02-02 22:39:42]

https://codereview.chromium.org/2673503002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/location_bar/location_bar_view.cc (right):

https://codereview.chromium.org/2673503002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/location_bar_view.cc:169: kBorderOpacity);
On 2017/02/02 00:51:35, Peter Kasting wrote:
> Even simpler: Leave kBorderColor as partly-transparent, and implement as:
> 
>   const SkColor toolbar_color =
>       ThemeProperties::GetDefaultColor(ThemeProperties::COLOR_TOOLBAR,
> incognito);
>   return color_utils::GetResultingPaintColor(kBorderColor, toolbar_color);
> 
> This allows reverting to one constant and continuing to pass the
> partly-transparent value in OnNativeThemeChanged() as before.

Done.

[Evan Stade, 2017-02-02 22:41:01]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-02-02 22:41:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2673503002/#ps60001
(title: "pkasting review")

[commit-bot: I haz the power, 2017-02-02 22:42:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 23:42:51]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486075261999610,
"parent_rev": "5fa41bde4dca431f3a6843bf20bebf90c2229a08", "commit_rev":
"ff3e5ef957ccb585c7d73a0b011bdd432f5e57e0"}

[commit-bot: I haz the power, 2017-02-02 23:43:26]

Description was changed from

==========
Slightly simplify location bar bg/border painting.

I also renamed some stuff to improve clarity (I couldn't initially 
determine why GetBorderColor didn't return the same thing as 
kBorderColor). This shouldn't cause any behavioral change. The unneeded 
complexity here was probably left over from pre-MD codepaths.

BUG=648281
==========

to

==========
Slightly simplify location bar bg/border painting.

I also renamed some stuff to improve clarity (I couldn't initially 
determine why GetBorderColor didn't return the same thing as 
kBorderColor). This shouldn't cause any behavioral change. The unneeded 
complexity here was probably left over from pre-MD codepaths.

BUG=648281

Review-Url: https://codereview.chromium.org/2673503002
Cr-Commit-Position: refs/heads/master@{#447881}
Committed:
https://chromium.googlesource.com/chromium/src/+/ff3e5ef957ccb585c7d73a0b011b...
==========

[commit-bot: I haz the power, 2017-02-02 23:43:27]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ff3e5ef957ccb585c7d73a0b011b...