Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2673483004: [ObjC ARC] Converts ios/chrome/browser/ui/tab_switcher:eg_tests to ARC. (Closed)

Created:
3 years, 10 months ago by stkhapugin
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/tab_switcher:eg_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2673483004 Cr-Commit-Position: refs/heads/master@{#448337} Committed: https://chromium.googlesource.com/chromium/src/+/983e068bc02286e6cd5f1c867e8ee2e7719e8322

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M ios/chrome/browser/ui/tab_switcher/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/tab_switcher/tab_switcher_controller_egtest.mm View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
stkhapugin
ptal
3 years, 10 months ago (2017-02-03 12:51:24 UTC) #6
marq (ping after 24h)
3 years, 10 months ago (2017-02-03 14:26:45 UTC) #7
marq (ping after 24h)
lgtm
3 years, 10 months ago (2017-02-03 14:28:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2673483004/1
3 years, 10 months ago (2017-02-06 17:49:15 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 19:12:38 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/983e068bc02286e6cd5f1c867e8e...

Powered by Google App Engine
This is Rietveld 408576698