Remove IdentityGetAuthTokenFunction interface dep on IdentityAPI

Remove IdentityGetAuthTokenFunction interface dep on IdentityAPI

In preparation for IdentityGetAuthTokenFunction being moved to its own
file, we must break the cyclic interface dependency between IdentityAPI
and IdentityGetAuthTokenFunction (identity_api.h will need to include
identity_get_auth_token_function.h for the extension registration
mechanism to see the latter). This CL removes IdentityAPI::ShutdownObserver
and replaces it with IdentityAPI directly calling
IdentityGetAuthTokenFunction::Shutdown().

BUG=685654
Review-Url: https://codereview.chromium.org/2673443002
Cr-Commit-Position: refs/heads/master@{#447970}
Committed: https://chromium.googlesource.com/chromium/src/+/202f1212a29d67d81515dfa55f31b0ec8501efb3

[blundell, 2017-02-01 19:33:35]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 19:34:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 20:19:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 20:19:55]

Dry run: This issue passed the CQ dry run.

[blundell, 2017-02-02 08:26:28]

blundell@chromium.org changed reviewers:
+ rockot@chromium.org

[Ken Rockot(use gerrit already), 2017-02-02 15:20:52]

lgtm

[Ken Rockot(use gerrit already), 2017-02-02 15:22:14]

BTW, it's a little weird to have a set_get_auth_token_function - do you see this
as a temporary state?

[blundell, 2017-02-02 15:26:27]

On 2017/02/02 15:22:14, Ken Rockot wrote:
> BTW, it's a little weird to have a set_get_auth_token_function - do you see
this
> as a temporary state?

The need for IdentityAPI to call into IdentityGetAuthTokenFunction on shutdown
cannot be worked around AFAICT. The other way I thought of doing this was:

- Give IdentityAPI a SetOnShutdownCallback() method that takes in a
base::Closure. Have IdentityGetAuthTokenFunction set/clear it as appropriate.

That seemed more-or-less equally strange, and somewhat more opaque. It has the
advantage of not having a really hard to parse and ambiguous name, though.

[blundell, 2017-02-03 08:24:47]

Going to land this, but happy to switch to the other approach if you like it
better.

[blundell, 2017-02-03 08:24:53]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2017-02-03 08:25:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 09:30:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486110293066030, "parent_rev":
"628896ee553990e2f0dc60a5a2c7b0b44535a10f", "commit_rev":
"202f1212a29d67d81515dfa55f31b0ec8501efb3"}

[commit-bot: I haz the power, 2017-02-03 09:30:59]

Description was changed from

==========
Remove IdentityGetAuthTokenFunction interface dep on IdentityAPI

In preparation for IdentityGetAuthTokenFunction being moved to its own
file, we must break the cyclic interface dependency between IdentityAPI
and IdentityGetAuthTokenFunction (identity_api.h will need to include
identity_get_auth_token_function.h for the extension registration
mechanism to see the latter). This CL removes IdentityAPI::ShutdownObserver
and replaces it with IdentityAPI directly calling
IdentityGetAuthTokenFunction::Shutdown().

BUG=685654
==========

to

==========
Remove IdentityGetAuthTokenFunction interface dep on IdentityAPI

In preparation for IdentityGetAuthTokenFunction being moved to its own
file, we must break the cyclic interface dependency between IdentityAPI
and IdentityGetAuthTokenFunction (identity_api.h will need to include
identity_get_auth_token_function.h for the extension registration
mechanism to see the latter). This CL removes IdentityAPI::ShutdownObserver
and replaces it with IdentityAPI directly calling
IdentityGetAuthTokenFunction::Shutdown().

BUG=685654

Review-Url: https://codereview.chromium.org/2673443002
Cr-Commit-Position: refs/heads/master@{#447970}
Committed:
https://chromium.googlesource.com/chromium/src/+/202f1212a29d67d81515dfa55f31...
==========

[commit-bot: I haz the power, 2017-02-03 09:31:00]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/202f1212a29d67d81515dfa55f31...