Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2673433002:
Fix in-process compositing on Windows 10. (Closed)
DescriptionFix in-process compositing on Windows 10.
DidCreateAcceleratedSurfaceChildWindow was not being implemented so the rendering
window wasn't being reparented to the browser window.
BUG=640748
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2673433002
Cr-Commit-Position: refs/heads/master@{#448713}
Committed: https://chromium.googlesource.com/chromium/src/+/16305b01e5fa25c11eff50d34238bc6576781fa4
Patch Set 1 #
Messages
Total messages: 25 (14 generated)
Description was changed from ========== Fix in-process compositing on Windows 10. DidCreateAcceleratedSurfaceChildWindow was not being implemented so the rendering window wasn't being reparented to the browser window. BUG=640748 ========== to ========== Fix in-process compositing on Windows 10. DidCreateAcceleratedSurfaceChildWindow was not being implemented so the rendering window wasn't being reparented to the browser window. BUG=640748 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
brettw@chromium.org changed reviewers: + jbauman@chromium.org
The CQ bit was checked by brettw@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
fsamuel@chromium.org changed reviewers: + fsamuel@chromium.org
I'm kind of surprised Mus+Ash doesn't suffer from the same problem on Windows...
On 2017/02/01 18:35:45, Fady Samuel wrote: > I'm kind of surprised Mus+Ash doesn't suffer from the same problem on Windows... This is Windows-10 only, could it be nobody's run it there?
non-OWNER lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_clang on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1486495510403750, "parent_rev":
"cae4d18a00b5dd78b62f9adb99a64985126d6e94", "commit_rev":
"16305b01e5fa25c11eff50d34238bc6576781fa4"}
Message was sent while issue was closed.
Description was changed from ========== Fix in-process compositing on Windows 10. DidCreateAcceleratedSurfaceChildWindow was not being implemented so the rendering window wasn't being reparented to the browser window. BUG=640748 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fix in-process compositing on Windows 10. DidCreateAcceleratedSurfaceChildWindow was not being implemented so the rendering window wasn't being reparented to the browser window. BUG=640748 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2673433002 Cr-Commit-Position: refs/heads/master@{#448713} Committed: https://chromium.googlesource.com/chromium/src/+/16305b01e5fa25c11eff50d34238... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/16305b01e5fa25c11eff50d34238... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
