Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: content/browser/media/capture/desktop_capture_device_aura_unittest.cc

Issue 2673373003: getUserMeida: report device starting states (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/capture/desktop_capture_device_aura_unittest.cc
diff --git a/content/browser/media/capture/desktop_capture_device_aura_unittest.cc b/content/browser/media/capture/desktop_capture_device_aura_unittest.cc
index 8f183081fd5583e1d8267d513767cbfcc1125569..25450396d9ae9f741250548daa86e1d4c9b2afd3 100644
--- a/content/browser/media/capture/desktop_capture_device_aura_unittest.cc
+++ b/content/browser/media/capture/desktop_capture_device_aura_unittest.cc
@@ -56,6 +56,7 @@ class MockDeviceClient : public media::VideoCaptureDevice::Client {
MOCK_METHOD2(OnError,
void(const tracked_objects::Location& from_here,
const std::string& reason));
+ MOCK_METHOD0(OnStarted, void(void));
miu 2017/02/09 22:21:49 Where does DesktopCaptureDeviceAura call OnStarted
miu 2017/02/09 22:21:49 One or more unit tests should probably EXPECT_CALL
braveyao 2017/02/14 01:05:48 It's called in ScreenCaptureDeviceCore::CaptureSta
braveyao 2017/02/14 01:05:48 Done. Thanks for the suggestion!
braveyao 2017/02/15 21:47:15 Oh, no. This test case is to stop immediately afte
// Trampoline methods to workaround GMOCK problems with std::unique_ptr<>.
Buffer ReserveOutputBuffer(const gfx::Size& dimensions,

Powered by Google App Engine
This is Rietveld 408576698