getUserMeida: report device starting states

content/browser/media/capture/desktop_capture_device_aura_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/media/capture/desktop_capture_device_aura.h"
 
 #include <stddef.h>
 #include <stdint.h>
 #include <utility>
 
@@ skipping 38 matching lines @@
                     base::TimeTicks reference_time,
                     base::TimeDelta tiemstamp,
                     int frame_feedback_id));
   MOCK_METHOD0(DoReserveOutputBuffer, void(void));
   MOCK_METHOD0(DoOnIncomingCapturedBuffer, void(void));
   MOCK_METHOD0(DoOnIncomingCapturedVideoFrame, void(void));
   MOCK_METHOD0(DoResurrectLastOutputBuffer, void(void));
   MOCK_METHOD2(OnError,
                void(const tracked_objects::Location& from_here,
                     const std::string& reason));
+  MOCK_METHOD0(OnStarted, void(void));

[miu, 2017/02/09 22:21:49]

Where does DesktopCaptureDeviceAura call OnStarted()?

[miu, 2017/02/09 22:21:49]

One or more unit tests should probably EXPECT_CALL(OnStarted), right?

[braveyao, 2017/02/14 01:05:48]

It's called in ScreenCaptureDeviceCore::CaptureStarted,
https://codereview.chromium.org/2673373003/diff/20001/media/capture/content/s....

In the past we only forward the ERROR report. Now Success report will be
forwarded to Client too.

[braveyao, 2017/02/14 01:05:48]

Done.

Thanks for the suggestion!

[braveyao, 2017/02/15 21:47:15]

Oh, no. This test case is to stop immediately after start. So OnStarted won't be
guaranteed to be called. At it seems that the screen capture doesn't really
started in this unittest.
I tried not to call Stop and there is still no OnStart event.
I tried the method in desktop_capture_device_unittest.cc to wait for the event
and it will time out.
No ChromeOS at my hand to investigate more right now. So add the
EXCEPT_CAll(OnStarted) as a placeholder for now.

 
   // Trampoline methods to workaround GMOCK problems with std::unique_ptr<>.
   Buffer ReserveOutputBuffer(const gfx::Size& dimensions,
                              media::VideoPixelFormat format,
                              media::VideoPixelStorage storage,
                              int frame_feedback_id) override {
     EXPECT_EQ(media::PIXEL_FORMAT_I420, format);
     EXPECT_EQ(media::PIXEL_STORAGE_CPU, storage);
     DoReserveOutputBuffer();
     return Buffer();
@@ skipping 90 matching lines @@
   media::VideoCaptureParams capture_params;
   capture_params.requested_format.frame_size.SetSize(640, 480);
   capture_params.requested_format.frame_rate = kFrameRate;
   capture_params.requested_format.pixel_format = media::PIXEL_FORMAT_I420;
   capture_device->AllocateAndStart(capture_params, std::move(client));
   capture_device->StopAndDeAllocate();
 }
 
 }  // namespace
 }  // namespace content