Fix regression where no IMEs appear in the opt-in IME menu

ImeMenuListView is the subclass of ImeListView. ImeListView calls 
Layout() in constructor, which is override by ImeMenuListView. There's
no guarantee that the ImeMenuListView::Layout() has been called.

Add ImeListView::Init() method for initializing the layout. Make the 
constructor simple by moving out all the updating layout logic. And 
call ImeListView::Init() after the instance created to make sure the 
overridden method has been called.

Also, move down the title label by 2px.


BUG=688940
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2673333002
Cr-Commit-Position: refs/heads/master@{#448513}
Committed: https://chromium.googlesource.com/chromium/src/+/d0cea0b2ad6f139ecd443d5b2ccd3fa7d1bfc3eb

[Azure Wei, 2017-02-06 07:50:45]

Description was changed from

==========
Fix list shown in opt-in ime menu.

BUG=688940
TEST=Verified on local build.
==========

to

==========
Call ImeMenuListView::Layout() in the constructor of ImeMenuListView. So
the scroll content would be shown correctly.

Also, move down the title label by 2px.

BUG=688940
TEST=Verified on local build.
==========

[Azure Wei, 2017-02-06 07:50:45]

azurewei@chromium.org changed reviewers:
+ tdanderson@chromium.org

[Azure Wei, 2017-02-06 07:57:00]

Please review this CL. Thanks!

[Azure Wei, 2017-02-06 08:33:03]

Description was changed from

==========
Call ImeMenuListView::Layout() in the constructor of ImeMenuListView. So
the scroll content would be shown correctly.

Also, move down the title label by 2px.

BUG=688940
TEST=Verified on local build.
==========

to

==========
ImeMenuListView is the subclass of ImeListView. ImeListView calls 
Layout() in constructor, which is override by ImeMenuListView. There's
no guarantee that the ImeMenuListView::Layout() has been called.

Add ImeListView::Init() method for initializing the layout. Make the 
constructor simple by moving out all the updating layout logic. And 
call ImeListView::Init() after the instance created to make sure the 
overridden method has been called.

Also, move down the title label by 2px.


BUG=688940
TEST=Verified on local build.
==========

[Azure Wei, 2017-02-06 08:33:03]

azurewei@chromium.org changed reviewers:
+ shuchen@chromium.org

[Azure Wei, 2017-02-06 09:57:59]

The CQ bit was checked by azurewei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 09:58:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 10:28:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 10:28:32]

Dry run: This issue passed the CQ dry run.

[tdanderson, 2017-02-06 22:41:35]

LGTM provided you have double-checked this also works with the IME detailed
view. Also please see my note on the bug regarding which milestone we should be
targeting.

https://codereview.chromium.org/2673333002/diff/40001/ash/common/system/chrom...
File ash/common/system/chromeos/ime_menu/ime_list_view.h (right):

https://codereview.chromium.org/2673333002/diff/40001/ash/common/system/chrom...
ash/common/system/chromeos/ime_menu/ime_list_view.h:3: // found in the LICENSE
file.
nit: For clarify can you please update the wording of the CL title to "Fix
regression where no IMEs appear in the opt-in IME menu" or similar?

https://codereview.chromium.org/2673333002/diff/40001/ash/common/system/chrom...
ash/common/system/chromeos/ime_menu/ime_list_view.h:29: // Initializes the
layout.
nit: For clarity I would reword as "Initializes the contents of a
newly-instantiated ImeListView" or similar.

https://codereview.chromium.org/2673333002/diff/40001/ash/common/system/chrom...
File ash/common/system/chromeos/ime_menu/ime_menu_tray.cc (right):

https://codereview.chromium.org/2673333002/diff/40001/ash/common/system/chrom...
ash/common/system/chromeos/ime_menu/ime_menu_tray.cc:157:
kTrayImageItemHorizontalPaddingVerticalAlignment, 0));
This constant is unrelated to what you're doing here. I suggest just hard-coding
a value of '1' here instead; we have plans to refactor this code in the near
future to use a TriView (crbug.com/689237).

[Azure Wei, 2017-02-07 01:06:07]

https://codereview.chromium.org/2673333002/diff/40001/ash/common/system/chrom...
File ash/common/system/chromeos/ime_menu/ime_list_view.h (right):

https://codereview.chromium.org/2673333002/diff/40001/ash/common/system/chrom...
ash/common/system/chromeos/ime_menu/ime_list_view.h:3: // found in the LICENSE
file.
On 2017/02/06 22:41:35, tdanderson wrote:
> nit: For clarify can you please update the wording of the CL title to "Fix
> regression where no IMEs appear in the opt-in IME menu" or similar?

Done. Thanks.

https://codereview.chromium.org/2673333002/diff/40001/ash/common/system/chrom...
ash/common/system/chromeos/ime_menu/ime_list_view.h:29: // Initializes the
layout.
On 2017/02/06 22:41:35, tdanderson wrote:
> nit: For clarity I would reword as "Initializes the contents of a
> newly-instantiated ImeListView" or similar.

Done. Thanks.

https://codereview.chromium.org/2673333002/diff/40001/ash/common/system/chrom...
File ash/common/system/chromeos/ime_menu/ime_menu_tray.cc (right):

https://codereview.chromium.org/2673333002/diff/40001/ash/common/system/chrom...
ash/common/system/chromeos/ime_menu/ime_menu_tray.cc:157:
kTrayImageItemHorizontalPaddingVerticalAlignment, 0));
On 2017/02/06 22:41:35, tdanderson wrote:
> This constant is unrelated to what you're doing here. I suggest just
hard-coding
> a value of '1' here instead; we have plans to refactor this code in the near
> future to use a TriView (crbug.com/689237).

Done. Updated as hard-coding of '1'.

[Azure Wei, 2017-02-07 01:06:11]

The CQ bit was checked by azurewei@chromium.org

[Azure Wei, 2017-02-07 01:06:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2673333002/#ps60001
(title: "")

[commit-bot: I haz the power, 2017-02-07 01:07:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 02:15:52]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486429571615210,
"parent_rev": "e4c513e7ae3fd3a6c7752f8add47b93fb1c66444", "commit_rev":
"d0cea0b2ad6f139ecd443d5b2ccd3fa7d1bfc3eb"}

[commit-bot: I haz the power, 2017-02-07 02:16:47]

Description was changed from

==========
ImeMenuListView is the subclass of ImeListView. ImeListView calls 
Layout() in constructor, which is override by ImeMenuListView. There's
no guarantee that the ImeMenuListView::Layout() has been called.

Add ImeListView::Init() method for initializing the layout. Make the 
constructor simple by moving out all the updating layout logic. And 
call ImeListView::Init() after the instance created to make sure the 
overridden method has been called.

Also, move down the title label by 2px.


BUG=688940
TEST=Verified on local build.
==========

to

==========
ImeMenuListView is the subclass of ImeListView. ImeListView calls 
Layout() in constructor, which is override by ImeMenuListView. There's
no guarantee that the ImeMenuListView::Layout() has been called.

Add ImeListView::Init() method for initializing the layout. Make the 
constructor simple by moving out all the updating layout logic. And 
call ImeListView::Init() after the instance created to make sure the 
overridden method has been called.

Also, move down the title label by 2px.


BUG=688940
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2673333002
Cr-Commit-Position: refs/heads/master@{#448513}
Committed:
https://chromium.googlesource.com/chromium/src/+/d0cea0b2ad6f139ecd443d5b2ccd...
==========

[commit-bot: I haz the power, 2017-02-07 02:16:48]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/d0cea0b2ad6f139ecd443d5b2ccd...