[parser] Skipping inner funcs: produce the same scopes / variables for loops.

[parser] Skipping inner funcs: produce the same scopes / variables for loops.

BUG=v8:5516
R=vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2673313003
Cr-Commit-Position: refs/heads/master@{#42957}
Committed: https://chromium.googlesource.com/v8/v8/+/01c2b45560cb8fa342f57520d0e19ec0ef9709da

[marja, 2017-02-06 08:59:08]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 08:59:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marja, 2017-02-06 09:14:04]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 09:14:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marja, 2017-02-06 09:14:11]

ptal

[commit-bot: I haz the power, 2017-02-06 09:39:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 09:39:42]

Dry run: This issue passed the CQ dry run.

[vogelheim, 2017-02-06 10:02:11]

lgtm

https://codereview.chromium.org/2673313003/diff/20001/src/parsing/preparser.h
File src/parsing/preparser.h (right):

https://codereview.chromium.org/2673313003/diff/20001/src/parsing/preparser.h...
src/parsing/preparser.h:1330:
(IsLexicalVariableMode(for_info->parsing_result.descriptor.mode) ||
super nitpick: Maybe hoist this expression into an additional bool, too.

bool requires_variable_declaration = is_for_var_of || IsLexicalVa...;
(... not sure that's a good name...)

https://codereview.chromium.org/2673313003/diff/20001/test/cctest/test-parsin...
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/2673313003/diff/20001/test/cctest/test-parsin...
test/cctest/test-parsing.cc:9363: // For of loops
Thank you for diligently adding test cases. Also, thanks for the group comments.

\o/

https://codereview.chromium.org/2673313003/diff/20001/test/cctest/test-parsin...
test/cctest/test-parsing.cc:9363: // For of loops
Two (totally optional) suggestions: (And probably for a future CL, anyhow.)

This doesn't ever seem to use the params field. I think you can drop a bit of
boilerplate and just turn inners into an array of strings.

test-parsing.cc was pretty unwieldy to start with. Maybe factor out new stuff
into a new cctest/test/parsing/*-test.cc file.

[marja, 2017-02-06 10:11:53]

thanks for review

https://codereview.chromium.org/2673313003/diff/20001/src/parsing/preparser.h
File src/parsing/preparser.h (right):

https://codereview.chromium.org/2673313003/diff/20001/src/parsing/preparser.h...
src/parsing/preparser.h:1330:
(IsLexicalVariableMode(for_info->parsing_result.descriptor.mode) ||
On 2017/02/06 10:02:11, vogelheim wrote:
> super nitpick: Maybe hoist this expression into an additional bool, too.
> 
> bool requires_variable_declaration = is_for_var_of || IsLexicalVa...;
> (... not sure that's a good name...)

added collect_names = ... here and in the corresponding place in parser.cc

https://codereview.chromium.org/2673313003/diff/20001/test/cctest/test-parsin...
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/2673313003/diff/20001/test/cctest/test-parsin...
test/cctest/test-parsing.cc:9363: // For of loops
On 2017/02/06 10:02:11, vogelheim wrote:
> Two (totally optional) suggestions: (And probably for a future CL, anyhow.)
> 
> This doesn't ever seem to use the params field. I think you can drop a bit of
> boilerplate and just turn inners into an array of strings.
> 
> test-parsing.cc was pretty unwieldy to start with. Maybe factor out new stuff
> into a new cctest/test/parsing/*-test.cc file.

Params field will be taken into use in a future CL.

I'll look into putting new stuff into a separate file; for that I'll also need
to separate a bunch of utils out of this file.

[marja, 2017-02-06 10:12:05]

The CQ bit was checked by marja@chromium.org

[marja, 2017-02-06 10:12:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2673313003/#ps40001
(title: "code review (vogelheim@)")

[commit-bot: I haz the power, 2017-02-06 10:12:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 10:40:01]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486375925217510,
"parent_rev": "ea7dc87cbd0652617865e8e0645e2905d94b7c65", "commit_rev":
"01c2b45560cb8fa342f57520d0e19ec0ef9709da"}

[commit-bot: I haz the power, 2017-02-06 10:40:04]

Description was changed from

==========
[parser] Skipping inner funcs: produce the same scopes / variables for loops.

BUG=v8:5516
R=vogelheim@chromium.org
==========

to

==========
[parser] Skipping inner funcs: produce the same scopes / variables for loops.

BUG=v8:5516
R=vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2673313003
Cr-Commit-Position: refs/heads/master@{#42957}
Committed:
https://chromium.googlesource.com/v8/v8/+/01c2b45560cb8fa342f57520d0e19ec0ef9...
==========

[commit-bot: I haz the power, 2017-02-06 10:40:05]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/01c2b45560cb8fa342f57520d0e19ec0ef9...