Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2673273002: Disable TruncatedTrace unit test in official builds. (Closed)

Created:
3 years, 10 months ago by Wez
Modified:
3 years, 10 months ago
Reviewers:
dcheng
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable TruncatedTrace unit test in official builds. Link-Time Optimization can lead to an insufficient number of stack trace entries to allow testing of stack trace truncation. Since the feature is really only for use in debugging during development, it's not critical that we test it work in Official builds. BUG=688570 Review-Url: https://codereview.chromium.org/2673273002 Cr-Commit-Position: refs/heads/master@{#448161} Committed: https://chromium.googlesource.com/chromium/src/+/ec97f91fba87e5bc67e496206b9f707779d4cffe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M base/debug/stack_trace_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Wez
PTAL
3 years, 10 months ago (2017-02-05 00:00:42 UTC) #4
dcheng
lgtm
3 years, 10 months ago (2017-02-05 00:31:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2673273002/1
3 years, 10 months ago (2017-02-05 00:33:33 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-05 01:31:12 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ec97f91fba87e5bc67e496206b9f...

Powered by Google App Engine
This is Rietveld 408576698