Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: content/child/webcrypto/shared_crypto_unittest.cc

Issue 267323009: [webcrypto] Add deriveBits key_op to JWK import/export. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/webcrypto/jwk.cc ('k') | content/child/webcrypto/webcrypto_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/webcrypto/shared_crypto_unittest.cc
diff --git a/content/child/webcrypto/shared_crypto_unittest.cc b/content/child/webcrypto/shared_crypto_unittest.cc
index 3beadc476170cd9b88ad1d7204d2ec19bf300580..005b32ef0d4cec580b040580557ff96fc89eb045 100644
--- a/content/child/webcrypto/shared_crypto_unittest.cc
+++ b/content/child/webcrypto/shared_crypto_unittest.cc
@@ -1185,7 +1185,6 @@ TEST_F(SharedCryptoTest, ImportJwkKeyUsage) {
const blink::WebCryptoAlgorithm algorithm;
const blink::WebCryptoKeyUsage usage;
};
- // TODO(padolph): Add 'deriveBits' key_ops value once it is supported.
const TestCase test_case[] = {
{"encrypt", "A128CBC", aes_cbc_algorithm,
blink::WebCryptoKeyUsageEncrypt},
@@ -1197,7 +1196,9 @@ TEST_F(SharedCryptoTest, ImportJwkKeyUsage) {
{"unwrapKey", "A128KW", aes_kw_algorithm,
blink::WebCryptoKeyUsageUnwrapKey},
{"deriveKey", "HS256", hmac_algorithm,
- blink::WebCryptoKeyUsageDeriveKey}};
+ blink::WebCryptoKeyUsageDeriveKey},
+ {"deriveBits", "HS256", hmac_algorithm,
+ blink::WebCryptoKeyUsageDeriveBits}};
Ryan Sleevi 2014/05/09 00:06:03 Hrm. Not sure if a spec bug or not that you can im
eroman 2014/05/09 00:36:49 It is not a spec bug, it is an implementation bug.
for (size_t test_index = 0; test_index < ARRAYSIZE_UNSAFE(test_case);
++test_index) {
SCOPED_TRACE(test_index);
« no previous file with comments | « content/child/webcrypto/jwk.cc ('k') | content/child/webcrypto/webcrypto_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698