[webcrypto] Add deriveBits key_op to JWK import/export.

content/child/webcrypto/shared_crypto_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/webcrypto/shared_crypto.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 1167 matching lines @@
             ImportKeyJwkFromDict(dict, aes_cbc_algorithm, false, 0, &key));
   EXPECT_EQ(0, key.usages());
 
   // Test each key_ops value translates to the correct Web Crypto value.
   struct TestCase {
     const char* jwk_key_op;
     const char* jwk_alg;
     const blink::WebCryptoAlgorithm algorithm;
     const blink::WebCryptoKeyUsage usage;
   };
-  // TODO(padolph): Add 'deriveBits' key_ops value once it is supported.
   const TestCase test_case[] = {
       {"encrypt", "A128CBC", aes_cbc_algorithm,
        blink::WebCryptoKeyUsageEncrypt},
       {"decrypt", "A128CBC", aes_cbc_algorithm,
        blink::WebCryptoKeyUsageDecrypt},
       {"sign", "HS256", hmac_algorithm, blink::WebCryptoKeyUsageSign},
       {"verify", "HS256", hmac_algorithm, blink::WebCryptoKeyUsageVerify},
       {"wrapKey", "A128KW", aes_kw_algorithm, blink::WebCryptoKeyUsageWrapKey},
       {"unwrapKey", "A128KW", aes_kw_algorithm,
        blink::WebCryptoKeyUsageUnwrapKey},
       {"deriveKey", "HS256", hmac_algorithm,
-       blink::WebCryptoKeyUsageDeriveKey}};
+       blink::WebCryptoKeyUsageDeriveKey},
+      {"deriveBits", "HS256", hmac_algorithm,
+       blink::WebCryptoKeyUsageDeriveBits}};

[Ryan Sleevi, 2014/05/09 00:06:03]

Hrm. Not sure if a spec bug or not that you can import HMAC keys that support
operations that the underlying algorithm does not...

[eroman, 2014/05/09 00:36:49]

It is not a spec bug, it is an implementation bug.

The spec says to fail such operations. Something I am going to work on next.

I will remove this then, since this isn't a valid long-term test

   for (size_t test_index = 0; test_index < ARRAYSIZE_UNSAFE(test_case);
        ++test_index) {
     SCOPED_TRACE(test_index);
     dict.SetString("alg", test_case[test_index].jwk_alg);
     key_ops->Clear();
     key_ops->AppendString(test_case[test_index].jwk_key_op);
     EXPECT_EQ(Status::Success(),
               ImportKeyJwkFromDict(dict,
                                    test_case[test_index].algorithm,
                                    false,
@@ skipping 2208 matching lines @@
                       algorithm,
                       CreateAesCbcAlgorithm(std::vector<uint8>(0, 16)),
                       true,
                       blink::WebCryptoKeyUsageEncrypt,
                       &unwrapped_key));
 }
 
 }  // namespace webcrypto
 
 }  // namespace content